JPEG lib broken in fltk-1.4?

[imacarthur]

My build (mingw) chokes building jpeg now:

[  2%] Building C object jpeg/CMakeFiles/fltk_jpeg.dir/jutils.c.obj
In file included from d:/Support/fltk-1.4/jpeg/jconfig.h:7:0,
                 from d:/Support/fltk-1.4/jpeg/jinclude.h:21,
                 from d:/Support/fltk-1.4/jpeg/jutils.c:16:
d:/Support/fltk-1.4/jpeg/fltk_jpeg_prefix.h:6:27: error: conflicting types for 'fltk_jcopy_sample_rows'
 #define jcopy_sample_rows fltk_jcopy_sample_rows
                           ^
d:/Support/fltk-1.4/jpeg/jutils.c:177:1: note: in expansion of macro 'jcopy_sample_rows'
 jcopy_sample_rows (JSAMPARRAY input_array,
 ^~~~~~~~~~~~~~~~~
d:/Support/fltk-1.4/jpeg/fltk_jpeg_prefix.h:6:27: note: previous declaration of 'fltk_jcopy_sample_rows' was here
 #define jcopy_sample_rows fltk_jcopy_sample_rows
                           ^
d:/Support/fltk-1.4/jpeg/jpegint.h:419:14: note: in expansion of macro 'jcopy_sample_rows'
 EXTERN(void) jcopy_sample_rows JPP((JSAMPARRAY input_array, int source_row,
              ^~~~~~~~~~~~~~~~~
make[2]: *** [jpeg/CMakeFiles/fltk_jpeg.dir/jutils.c.obj] Error 1
make[1]: *** [jpeg/CMakeFiles/fltk_jpeg.dir/all] Error 2
make: *** [all] Error 2

[Albrecht Schlosser]

On 1/17/23 12:58 imacarthur wrote:
> My build (mingw) chokes building jpeg now:
>
> [  2%] Building C object jpeg/CMakeFiles/fltk_jpeg.dir/jutils.c.obj
> In file included from d:/Support/fltk-1.4/jpeg/jconfig.h:7:0,
>                  from d:/Support/fltk-1.4/jpeg/jinclude.h:21,
>                  from d:/Support/fltk-1.4/jpeg/jutils.c:16:
> d:/Support/fltk-1.4/jpeg/fltk_jpeg_prefix.h:6:27: error: conflicting
> types for 'fltk_jcopy_sample_rows'

FYI: Manolo updated libjpeg at about 12:30 UTC in commit
2f09e96b6d478a56484bdb6d771a3dced8c37126 and added two further commits
at 12:45 and 13:09 UTC.

Latest commit: 3774a0b0a9d508de4d37d9c32ffd8b82bd7f5719

You may need to pull the latest changes.

Tested on Linux, cross-compiling for Windows (MinGW): works for me.

[Albrecht Schlosser]

On 1/17/23 14:50 Albrecht Schlosser wrote:
>
> FYI: Manolo updated libjpeg at about 12:30 UTC in commit
> 2f09e96b6d478a56484bdb6d771a3dced8c37126

Sorry, that should read "11:30 UTC".

[imacarthur]

On Tuesday, 17 January 2023 at 13:54:20 UTC Albrecht Schlosser wrote:

On 1/17/23 14:50 Albrecht Schlosser wrote:
>
> FYI: Manolo updated libjpeg at about 12:30 UTC in commit
> 2f09e96b6d478a56484bdb6d771a3dced8c37126

 OK - works again after a fresh pull. I must have caught it between commits...

Ta!