blocking tests hanging
10 views
Skip to first unread message
Richard Lee
Jun 10, 2011, 4:14:45 PM6/10/11
to Flexunit Contributors
Hmm... my previous post from yesterday hasn't appeared yet, or I would
respond to it.
Turns out the *root* problem is actually using the ant Execute class
in Command.java without an ExecuteWatchdog, as currently the launch of
the player blocks the calling process until it exits. Thus, if it
never exits, the exception from the Future<> is never handled. So, I
changed Command.launch() to take a msec timeout argument that I pass
to a watchdog that I pass to Execute and then it times out correctly!
I think this is a bug that should be fixed.
Richard
respond to it.
Turns out the *root* problem is actually using the ant Execute class
in Command.java without an ExecuteWatchdog, as currently the launch of
the player blocks the calling process until it exits. Thus, if it
never exits, the exception from the Future<> is never handled. So, I
changed Command.launch() to take a msec timeout argument that I pass
to a watchdog that I pass to Execute and then it times out correctly!
I think this is a bug that should be fixed.
Richard
Simeon Bateman
Jun 10, 2011, 5:13:44 PM6/10/11
to Flexunit Contributors
Hi Richard,
If you haven't already, it would be great if you could fork the
project on github and submit a pull request for the bug.
Then we can integrate the change and get it into our next release. We
are currently working on a bug fix release 4.1.1 due out next week we
hope.
Thanks,
simeon
If you haven't already, it would be great if you could fork the
project on github and submit a pull request for the bug.
Then we can integrate the change and get it into our next release. We
are currently working on a bug fix release 4.1.1 due out next week we
hope.
Thanks,
simeon
Richard Lee
Jun 10, 2011, 7:14:04 PM6/10/11
to flexunit-c...@googlegroups.com
Alright... not exactly sure how to fork a github project, but I'll poke
around for some docs. If you have any 'get started quick' doc you can
point me at, it would be appreciated.
around for some docs. If you have any 'get started quick' doc you can
point me at, it would be appreciated.
Also, it would be nice to be able to pass optional arguments to air
applications being run in flexunit. Any objections to adding an extra
parameter to the ant task for this? The reason I want this is so that I
can collect emma coverage reports using flexcover via the approach
described at eyefodder.com which requires that arguments be passed to
the air based flexunit test.
Richard
Richard Lee
Jun 21, 2011, 1:09:02 PM6/21/11
to Flexunit Contributors
Ok... uploaded my changes to github and submitted a pull request. Any
chance this makes it into the next release?
Richard
chance this makes it into the next release?
Richard
Simeon Bateman
Jul 1, 2011, 11:57:45 PM7/1/11
to Flexunit Contributors
Hi Richard,
Thanks so much for this. I have the pull request but have not had any
time to merge it.
The only outstanding item is getting an adobe contributor agreement
signed for you. I'll message you on github to get that started.
I am doing some testing of our other outstanding issues this weekend.
So hopefully we can get your stuff integrated and the bugfix release
out the door.
Thanks,
simeon
Thanks so much for this. I have the pull request but have not had any
time to merge it.
The only outstanding item is getting an adobe contributor agreement
signed for you. I'll message you on github to get that started.
I am doing some testing of our other outstanding issues this weekend.
So hopefully we can get your stuff integrated and the bugfix release
out the door.
Thanks,
simeon
Reply all
Reply to author
Forward
0 new messages