Flatbuffers reflection for java

[Romain Gilles]

Hi all,

I would like to first thank for this project. It sounds really promising for me.

I would like to known if you are working on a java api for reflection; something inspired by the c++ one?

Thanks in advance.

Romain.

[Wouter van Oortmerssen]

I am personally not working on that at this time. I may get to it eventually, or an external contributor could add it.

--
You received this message because you are subscribed to the Google Groups "FlatBuffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to flatbuffers...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Romain Gilles]

Thank you for your answer.

I hope by the end of this week I will be able to say if I can contribute.

Thanks,

Roomain

[Romain Gilles]

Hi,

I have done some testing of flatbuffers and it is exactly what I'm looking for. I will be very please to contribute. If you don't mind I would like to try to implement the reflection api for java, with your support!

It is ok for you?

Regards,

Romain.

Le lundi 23 mai 2016 18:27:03 UTC+2, Wouter van Oortmerssen a écrit :

[Wouter van Oortmerssen]

Romain,

That sounds great!

Make sure you have a good understand on how the C++ version accomplishes reflection. Another thing that will be important is good tests, as getting the implementation right is tricky.

Feel free to make a PR early, so we can see if we're going in the right direction.

[Romain Gilles]

Hi Wouter,

Can I propose you to use maven in the java project part to compile and run the unit test?

I see that the Java test case are written in a single test class JavaTest. Is it the only way to test or can we enable / setup maven project to run JUnit or Testng or ... to code the test case?

If you want I usually work with maven so if you want I can restructure the java sub project.

What do you think I will follow your vision?

Romain.

[Wouter van Oortmerssen]

We have plans to better support Maven, I just haven't gotten to it yet (I'm not an active  Java programmer myself).

Lets do it in three steps, to keep PRs reviewable. First, reflection and tests for the reflection as something called from JavaTest. Then in seperate PRs, we can add Maven based build&test, then after, we can see what is involved in adding JUnit, ok?

[Romain Gilles]

Ok,

I say that because I was about to add also an maven for JMH project in order to micro bench the technical options.

Romain 

[Romain Gilles]

And I was about to make it OSGi compliant too.

[Romain Gilles]

I can do it in a separate pull request and you will see the impact.

Romain

[Wouter van Oortmerssen]

Yes, even if you want to do it before you start on reflection, keeping PRs as small and simple as possible is preferred :)

[Romain Gilles]

Hi,

I create the pull request for project structure: https://github.com/google/flatbuffers/pull/3902

Please let me know if you think it's a good idea or not. After that I will work on the reflection api based on your feedbacks.

I can understand that this kind of restructuration of a project is dangerous.

Regards,

Romain.

[Romain Gilles]

Hi Wounter
Did you have time to have a look to my pull request? As soon as you accept or reject it I jump on the reflection.

Regards,

Romain.

[Wouter van Oortmerssen]

Sorry, been busy :)

Romain.

--
You received this message because you are subscribed to the Google Groups "FlatBuffers" group.

[Ranger]

Hi Romain,

I'm working in a project that uses FlatBuffers to store data. I'm working in both C++ and Java languages and it is nice to use reflection in C++ side. I wanna use reflection in Java same as in C++ but there are no sources up to now. How is your progress, are you done with it? Reflection in Java is the thing I really need right now.

Thanks,

Quan Nguyen Hoang

[Romain Gilles]

Hi,

Sorry for the delay!

For now I'm too busy to work on it. If nobody has started I think I will be able to work on it by the end of August...

Sorry,

Romain 

[Romain Gilles]

Hi Wouter

Can I start on this subject?

Thanks,

Romain

[Wouter van Oortmerssen]

Sure, go ahead. You'll be working on reflection now, correct?

--

You received this message because you are subscribed to the Google Groups "FlatBuffers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flatbuffers+unsubscribe@googlegroups.com.

[Romain Gilles]

Yes I would like to start to work on Java reflection

To unsubscribe from this group and stop receiving emails from it, send an email to flatbuffers...@googlegroups.com.

[Romain Gilles]

BTW: I added some comments to my last PR : https://github.com/google/flatbuffers/pull/4003
I think, I know why you have the strange class loading issue.
Please have a look and let me know.

Regards

Romain.

[Romain Gilles]

Hi Wouter,

I have started to play with the reflection for Java. 

I'm waiting from you to validate (or reject) my previous pull request to start a new one on reflection.

I have some comments (/ remarks) on it, I would like to share with you...

Thanks,

Romain.

[Wouter van Oortmerssen]

Sorry for the delay, merged the other one.

--

You received this message because you are subscribed to the Google Groups "FlatBuffers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to flatbuffers+unsubscribe@googlegroups.com.