session.cpp updates

67 views
Skip to first unread message

Cinar Eren

unread,
Nov 21, 2018, 9:01:19 AM11/21/18
to fix8 developer
Hello,

I want to ask for your comments on some updates in session.cpp:

1. On line 831, seqno is not updated for the logout message. I plan to update it so that seqno will be updated. Do you think i miss something?

2. for the messages handled in process() method, if an f8exception is caught, loginparameter.reliable is checked and exception is thrown in case of reliability. However this is not done under send() message. So in case a connection problem is caught during a send(), reliableclientsession misses the chance to retry. Do you think it will be a problem in case i throw those exceptions for loginparameter.reliable cases?

3. session state is not updated to st_logoff_received. Shouldnt we have a do_state_change(States::st_logoff_received) under handle_logout?

hope to hear your comments.

best regards.
Reply all
Reply to author
Forward
0 new messages