<xul:browser> changes incoming: XBL -> Custom Element conversion

78 views
Skip to first unread message

Brian Grinstead

unread,
Jan 8, 2019, 4:30:11 PM1/8/19
to Firefox Dev
This is a heads up that I’m planning to land a conversion of the XBL portion of the XUL browser element to a Custom Element in https://bugzilla.mozilla.org/show_bug.cgi?id=1441935. The current implementation is in toolkit/content/widgets/browser.xml, and the new one will be in toolkit/content/widgets/browser-custom-element.js (history will be kept on the new file since it'll be moved in hg).

In theory this shouldn’t change too much since there’s a lot of test coverage, the changes were mostly automated, and a bunch of prerequisite work has been done in blockers over the last couple of months. That said, there are differences with the timing for XBL binding construction (based on layout or JS access, whichever happens first… usually) vs Custom Element construction (based on DOM connection), so there’s always the possibility for unexpected changes. Please let me know if you see any issues that seem related to the browser element after this lands.

There are around 3 weeks left until the next merge (2019-01-28). With any luck and pending a couple of final test runs, I'm hoping to land this today or tomorrow.

Thanks,
Brian

_______________________________________________
firefox-dev mailing list
firef...@mozilla.org
https://mail.mozilla.org/listinfo/firefox-dev

Brian Grinstead

unread,
Jan 10, 2019, 12:19:21 PM1/10/19
to Firefox Dev
This has now landed. Thanks again to Mike Conley for the reviews and to Neil Deakin for fixing the last major blocker for this one (bug 1492326).

Brian
Reply all
Reply to author
Forward
0 new messages