Please use the wantLoad argument of BrowserTestUtils.browserLoaded()

11 views
Skip to first unread message

Henri Sivonen

unread,
Oct 27, 2023, 5:47:33 AM10/27/23
to firef...@mozilla.org
In https://bugzilla.mozilla.org/show_bug.cgi?id=543435 , I'm changing our initial about:blank behavior to be Chrome-compatible.

While tests that have a Web point of view (WPT, mochitest-plain) (largely) work already, there's a large number of browser-chrome tests that still fail. The most common failure mode seems to be that BrowserTestUtils.browserLoaded() is used without the wantLoad argument and an unwanted about:blank load is caught.

When writing new tests, please use the wantLoad argument if at all possible when using BrowserTestUtils.browserLoaded().

(At least for now, I'm aiming to make the XUL browser element behavior consistent with HTML iframes while making HTML iframes consistent with HTML iframes in Chrome. There may be performance reasons to do something different once this works.)

--
Henri Sivonen
hsiv...@mozilla.com

--
You received this message because you are subscribed to the Google Groups "firef...@mozilla.org" group.
To unsubscribe from this group and stop receiving emails from it, send an email to firefox-dev...@mozilla.org.
To view this discussion on the web visit https://groups.google.com/a/mozilla.org/d/msgid/firefox-dev/CAJHk%2B8S_p-g3%3DmsXKDqRvUj0iGHohKnNu9e%2BXpSXZwGJc7zEAg%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages