a patch to add Jquery/Dojo selector to firefirender

23 views
Skip to first unread message

l.gualtieri

unread,
Mar 24, 2010, 4:05:52 AM3/24/10
to Firefinder
Hi group,
I worked for a long time with firefinder and I don't have to explain
you how it's useful.
I spend a lot of time dealing with jquery selector, so last night I
mumbled if was possible
add this feature to firefinder.
So I've modified the original code to add sizzle engine support, at
the moment it's
just a quick&dirty patch ... but works pretty well without changing
the original behavior
Anyone interessed ?

Thanks for the attention,
l.

Robert Nyman

unread,
Mar 24, 2010, 4:14:18 AM3/24/10
to firef...@googlegroups.com
Hi,

Interesting! The first version actually used Sizzle for the selectors, but then I went for the native querySelectorAll support, for the best possible performance and light-weight code.
However, if you want to, please post somewhere where it can be downloaded for those that are interested.


Best regards,
Robert 




--
You received this message because you are subscribed to the Google Groups "Firefinder" group.
To post to this group, send email to firef...@googlegroups.com.
To unsubscribe from this group, send email to firefinder+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/firefinder?hl=en.


l.gualtieri

unread,
Mar 24, 2010, 5:08:56 AM3/24/10
to Firefinder
Hi Robert,
I've uploaded the modified files to this url:

http://ggsfoundry.altervista.org/patch-to-add-jquery-selecter-to-firefinder.zip

The Sizzle engine based evaluation is triggered by writing the
selector using jquery syntax.

e.g. $('a')

Bye,
Luigi


On Mar 24, 9:14 am, Robert Nyman <robny...@gmail.com> wrote:
> Hi,
>
> Interesting! The first version actually used Sizzle for the selectors, but
> then I went for the native querySelectorAll support, for the best possible
> performance and light-weight code.
> However, if you want to, please post somewhere where it can be downloaded
> for those that are interested.
>
> Best regards,
> Robert
>

> On Wed, Mar 24, 2010 at 9:05 AM, l.gualtieri <luigi.gualti...@gmail.com>wrote:
>
> > Hi group,
> > I worked for a long time with firefinder and I don't have to explain
> > you how it's useful.
> > I spend a lot of time dealing with jquery selector, so last night I
> > mumbled if was possible
> > add this feature to firefinder.
> > So I've modified the original code to add sizzle engine support, at
> > the moment it's
> > just a quick&dirty patch ... but works pretty well without changing
> > the original behavior
> > Anyone interessed ?
>
> > Thanks for the attention,
> > l.
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Firefinder" group.
> > To post to this group, send email to firef...@googlegroups.com.
> > To unsubscribe from this group, send email to

> > firefinder+...@googlegroups.com<firefinder%2Bunsu...@googlegroups.com>

Robert Nyman

unread,
Mar 24, 2010, 6:03:36 AM3/24/10
to firef...@googlegroups.com
Great, thanks!


Best regards,
Robert




To unsubscribe from this group, send email to firefinder+...@googlegroups.com.

reesd

unread,
Feb 17, 2011, 12:30:50 PM2/17/11
to firef...@googlegroups.com
Robert, Any plans to include this patch? I'm using it successfully and the jQuery crowd is a big one :). You might make it simple by just allowing people to prepend the query with a $. So "$table//a" rather than "$('table//a').

@l.gualtieri, This really is jQuery, right? Dojo doesn't use sizzle and only supports CSS from what I have researched (unless you do a custom build). Or am I missing something?

Thanks,
d

Luigi Gualtieri

unread,
Feb 17, 2011, 12:42:26 PM2/17/11
to firef...@googlegroups.com
It's css selector engine used by jquery and developed by dojo foundation.
In order to avoid some compatibility issues you have to use a special 'browser detection tricks' stripped version of sizzle.
The original sizzle breaks web developer toolbar.

No problem, for me,  for patch inclusion

bye 


2011/2/17 reesd <da...@ubiqsoft.com>

--

Robert Nyman

unread,
Feb 18, 2011, 3:55:05 AM2/18/11
to firef...@googlegroups.com
For me, I've always also seen Firefinder as a tool for native CSS, as in rules in a specification and not by JavaScript-library specific rules.
I don't like the dependency, and risk of future library updates that won't be reflected in Firefinder. Besides, custom selectors in JavaScript libraries, while easy to ready, are not near as performant as native CSS since you can utilize query SelectorAll for that, but custom selectors needs to do loopoing and all kinds of manual workarounds.

So, while I do acknowledge the need and interest, I'm a bit weary about including it in Firefinder.


Best regards,
Robert


--

David Rees

unread,
Feb 18, 2011, 9:13:18 AM2/18/11
to firef...@googlegroups.com

Your extension, so your call of course. I think you are missing out on the huge user jQuery use base though. To be clear, I am suggesting adding it as an option – native CSS and XPath would be the default unless you entered the $ (or you could add a drop-down). Just something to think about.

 

d

Robert Nyman

unread,
Feb 18, 2011, 9:18:14 AM2/18/11
to firef...@googlegroups.com
I do understand that for jQuery fans it could be quite useful. But at the same time, it means Firefinder will need to be updated every time jQuery is, test and compatibility matches will need to be done etc.
So while it works now, it could be  a dependency that will consistently need to be maintained.

If other people want to get in and help out with Firefinder, great, and then we can talk about that. But currently, when it's only me developing, it's not something I want to get into at this moment, due to lots of other things I focus at at this time.


Best regards,
Robert 
Reply all
Reply to author
Forward
0 new messages