Some patches for Firedrop 0.2.2

3 views
Skip to first unread message

Adalbert Prokop

unread,
Sep 14, 2006, 3:34:57 PM9/14/06
to fire...@googlegroups.com
Hello!

Today I found some time to play with firedrops source code. In the past
I've found some bugs - or a behaviour I was not content with. So today
I've created patches for it.

* firedrop2-0.2.2-noblueopen.patch

Firedrop highlights the buttons when the mouse hovers over them, but the
original colour is not restored afterwards. I think I've posted this
patch already but it was buggy itself. The buttons at the bottom of
Firedrop's window stopped working. With this corrected patch they work
again.

* firedrop2-0.2.2-createnewentrydialog.patch

Every time the window for new blog entry has been opened, Firedrop has
overwritten the entry.ini file in the config directory with hard-coded
defaults.

* firedrop2-0.2.2-entry_ini.patch

There is an entry for the desired format of the blog entries in
entry.ini, but it has been ignored until now. This patch reads the
desired entry style and sets it the new entry dialog.

All patches can also be found on
http://www.familie-prokop.de/firedrop/index_en.html

bye,
Adalbert
--
nesting roaches shorted out the ether cable

firedrop2-0.2.2-createnewentrydialog.patch
firedrop2-0.2.2-entry_ini.patch
firedrop2-0.2.2-noblueopen.patch

Michael Foord

unread,
Sep 14, 2006, 5:16:25 PM9/14/06
to fire...@googlegroups.com
Adalbert Prokop wrote:
> Hello!
>
> Today I found some time to play with firedrops source code. In the past
> I've found some bugs - or a behaviour I was not content with. So today
> I've created patches for it.
>
>
Thanks Adalbert - these are really appreciated.

If you're certain that these patches are compatible with Windows, I can
give you Subversion check-in rights.

Unfortunately it is likely to be a while before I can get round to doing
a new release, but I will get there...

Fuzzyman
http://www.voidspace.org.uk/python/index.shtml

Stewart Midwinter

unread,
Sep 14, 2006, 5:41:28 PM9/14/06
to fire...@googlegroups.com
hey, good stuff.

I noticed some of those problems while hacking on Firedrop earlier this year, but they took a back seat to other priorities at the time. Nice to see them get some attention now. 

There may be issues raised in the Trac ticketing application over at http://firedrop2.python-hosting.com/

BTW, it looks like the home page there got whacked, as all the content has disappeared. The project timeline is unavailable, and there are a good number of spam entries in the list of tickets.

cheers
Stewart

Michael Foord

unread,
Sep 14, 2006, 6:12:16 PM9/14/06
to fire...@googlegroups.com
*damn*

They all need reverting, and the Wiki setting so that it can only be
edited by people who are logged in. *sigh*

Fuzzyman
http://www.voidspace.org.uk/python/index.shtml

>
> cheers
> Stewart
>
>
> >

Adalbert Prokop

unread,
Sep 15, 2006, 2:25:01 AM9/15/06
to fire...@googlegroups.com
Michael Foord schrieb am Donnerstag, 14. September 2006 23:16:

Hi!

> If you're certain that these patches are compatible with Windows, I can
> give you Subversion check-in rights.

That's a good question. As Donald E. Knuth said: "Beware of bugs in the
above code; I have only proved it correct, not tried it."
The patches work fine for me, I've tested them on my Linux box and the
code does not use any Windows-dependent functions, only Firedrop's
internal methods. Ergo the should work fine.

By the way: did the problem with blue highlighted buttons ever show up on
Windows?

Bye,
Adalbert
--
My father was a saint, I'm not. -- Indira Gandhi

Reply all
Reply to author
Forward
0 new messages