[firebreath/FireBreath] 6922ab: Stable eventId for NPObjectAPI.

2 views
Skip to first unread message

GitHub

unread,
Jan 27, 2014, 11:24:53 AM1/27/14
to firebre...@googlegroups.com
Branch: refs/heads/firebreath-1.7
Home: https://github.com/firebreath/FireBreath
Commit: 6922ab4bd4325681e95872e0c38471cf7c0b9dfa
https://github.com/firebreath/FireBreath/commit/6922ab4bd4325681e95872e0c38471cf7c0b9dfa
Author: Byron Clark <bcl...@hirevue.com>
Date: 2013-09-08 (Sun, 08 Sep 2013)

Changed paths:
M src/ActiveXCore/IDispatchAPI.h
M src/NpapiCore/NPObjectAPI.cpp
M src/NpapiCore/NPObjectAPI.h
M src/ScriptingCore/JSAPIImpl.cpp
M src/ScriptingCore/JSObject.h
M src/WebKitCore/JSObjectRefAPI.h

Log Message:
-----------
Stable eventId for NPObjectAPI.

Safari rewraps a Javascript function for each call. This means that
removeEventListener will never remove a listener set by
addEventListener. Use a sequence to set the eventId in the __fb_event_id
property on the Javascript object so that we'll be able to see it when
the object is passed in. Unfortunately, this requires removing the const
flag on getEventId.


Commit: 105dcc6799024007cc773ef7532e8f91298a11c6
https://github.com/firebreath/FireBreath/commit/105dcc6799024007cc773ef7532e8f91298a11c6
Author: Richard Bateman <taxi...@gmail.com>
Date: 2014-01-27 (Mon, 27 Jan 2014)

Changed paths:
M src/ActiveXCore/IDispatchAPI.h
M src/NpapiCore/NPObjectAPI.cpp
M src/NpapiCore/NPObjectAPI.h
M src/ScriptingCore/JSAPIImpl.cpp
M src/ScriptingCore/JSObject.h
M src/WebKitCore/JSObjectRefAPI.h

Log Message:
-----------
Merge pull request #118 from byronclark/safari-event-id-cleanup

Stable Event IDs for Safari


Compare: https://github.com/firebreath/FireBreath/compare/c335f5b70703...105dcc679902
Reply all
Reply to author
Forward
0 new messages