Visual Studio 2017 support

[Joseph Wu]

Hi All,

  Does FireBreath 2.0 support VS2017 now? If not could anyone show me how to do this. I made few changes in FB_ROOT/cmake/Win.cmake, but not work yet.

  Any suggestion will be appreciated.

Thanks,
Joseph

[Bart Lievens]

Hello,

the prepVisualStudio.cmd was added to build with VS2017.  

What I do to build is with VS2017 is :

FB_ROOT\prepVisualStudio.cmd "Visual Studio 15 2017" <project_dir> <build_dir> [extra_options]

this will give you <build_dir>\<plugin>.sln  you can build with VS2017, you can do this from command line with :

<visual_studio_bin_path>\MSBuild.exe <build_dir>\<plugin>.sln /t:build

Bart

[Joseph Wu]

Hi Bart,

  Thanks for the reply. Did this work with the latest 2.0 branch?
  I got error which has problem to find ATL libraries, reported by "if (ATLWIN AND ATLLIB)" in Win.cmake. It works after I hard coded lots of variables (VS_DIR, ATL include dir, ATL lib dir) in Win.cmake to the correct path of VS2017.
  Could you show me your Win.cmake which could support VS2017 ATL library?

Thanks,
Joseph

在 2018年3月13日星期二 UTC+8下午2:16:36，Bart Lievens写道：

[Richard Bateman]

are you using the free version of vs2017 or professional? ATL isn't included in the free version and you have to find it elsewhere.

Richard

--

---
You received this message because you are subscribed to the Google Groups "firebreath-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to firebreath-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Bart Lievens]

Hello,

I'm using Visual studio express 2017 (the free version),  and it's working without any changes to the cmake files..

But you could try with turning on "ATL support" in you Visual Studio:

Go to visual studio installer -> "Visual Studio Communiity 2017", select modify , if you select "Desktop development with C++" you can check the box in summary on right of "Visual C++ ATL support" .

That is turned on in my setup, I don't remember if I had to download & install something or if it was there by default (but maybe not turned on by default).

To unsubscribe from this group and stop receiving emails from it, send an email to firebreath-de...@googlegroups.com.

[Joseph Wu]

Hi Richard, Bart,

  I'm using VS2017 Professional (15.6.1, the same problem with 15.5.2 before I uninstall it). ATL library is located at "C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.13.26128\atlmfc".

  I found the rule of finding the path of ATL lib is changed in VS2017. So I made below changes in cmake/Win.cmake. It only works for me as I hard coded the MSVC path to a specific version number.
 

 

Thanks,
Joseph

在 2018年3月14日星期三 UTC+8上午2:26:27，Bart Lievens写道：

[Joseph Wu]

CMake is upgraded to 3.10.2 from 3.2 to support VS2017.

在 2018年3月14日星期三 UTC+8上午8:09:45，Joseph Wu写道：

[Bart Lievens]

Hello,

I checked my setup and I'm using CMake v3.8.0.

I also had a look at the CMake documentation and cmake generator for "Visual Studio 15 2017" seems to be added in version 3.7  : https://cmake.org/cmake/help/v3.7/manual/cmake-generators.7.html 

[Joseph Wu]

Hi Bart,

  Yes, CMake supports VS2017 now. The problem I met are VS2017 path ATL path problems for firebreath.

Thanks,
Joseph

在 2018年3月14日星期三 UTC+8下午2:22:35，Bart Lievens写道：