Security database upgrade instructions in Firebird 3 release notes

[Mark Rotteveel]

I'm starting with a Firebird 5 Quick Start Guide, and while doing that,
I was looking at the Firebird 3 release notes, specifically, the steps
to upgrade the security database (see [1]).

It seems to me that step 5 is wrong. The upgrade script creates the new
users with `CREATE USER`, so they would end up in the normal security
database (security3.fdb), not in the "old" security database
(security2db.fdb). So, security3.fdb should not be deleted and replaced
with the "upgraded database".

I'll fix this, but I'm curious how we didn't pick up on this, and I
can't recall people complained about this...

Mark

[1]:
https://www.firebirdsql.org/file/documentation/release_notes/html/en/3_0/rlsnotes30.html#rnfb30-compat-upgrade-secdb
--
Mark Rotteveel

[Dimitry Sibiryakov]

'Mark Rotteveel' via firebird-devel wrote 02.11.2023 11:07:
> I'm curious how we didn't pick up on this, and I can't recall people complained
> about this...

Most likely nobody ever followed or even read this instruction doing simple
backup-restore of security database and enable legacy auth.
Migration process that loses all user password is next to useless.

--
WBR, SD.

[Vlad Khorsun]

02.11.2023 12:07, 'Mark Rotteveel' via firebird-devel:

> I'm starting with a Firebird 5 Quick Start Guide, and while doing that, I was looking at the Firebird 3 release notes, specifically,
> the steps to upgrade the security database (see [1]).
>
> It seems to me that step 5 is wrong. The upgrade script creates the new users with `CREATE USER`, so they would end up in the normal
> security database (security3.fdb), not in the "old" security database (security2db.fdb). So, security3.fdb should not be deleted and
> replaced with the "upgraded database".

Good catch !

> I'll fix this, but I'm curious how we didn't pick up on this, and I can't recall people complained about this...

Perhaps people read "misc\upgrade\security\security_database.txt" that have no such step.

> Mark
>
>  [1]: https://www.firebirdsql.org/file/documentation/release_notes/html/en/3_0/rlsnotes30.html#rnfb30-compat-upgrade-secdb

Regards,
Vlad