Class OpenEvents in src/common/os/win32/isc_ipc.cpp

[Adriano dos Santos Fernandes]

Hi!

This class, through the global openEvents variable, looks to be
incorrectly used without any synchronization.


Adriano

[Vlad Khorsun]

06.08.2025 3:08, Adriano dos Santos Fernandes:

> Hi!
>
> This class, through the global openEvents variable, looks to be
> incorrectly used without any synchronization.

It used in Classic only, iirc

Regards,
Vlad

[Adriano dos Santos Fernandes]

Isn't it a problem for SuperClassic?


Adriano

[Vlad Khorsun]

06.08.2025 13:39, Adriano dos Santos Fernandes:

For single process - no. But we need to analyze multi-process case.

Regards,
Vlad

[Vlad Khorsun]

06.08.2025 13:54, Vlad Khorsun:

Well, it seems that sync is needed in this case. I think simple mutex in
OpenEvents::getEvent() is enough and should not harm in single-proces case.
Do you want me to add it, or you already doing it ?

Regards,
Vlad

[Adriano dos Santos Fernandes]

   Well, it seems that sync is needed in this case. I think simple mutex in
OpenEvents::getEvent() is enough and should not harm in single-proces case.
Do you want me to add it, or you already doing it ?

Please do it.

Adriano

[Vlad Khorsun]

07.08.2025 0:16, Adriano dos Santos Fernandes:

Done in master, to be backported after QA pass.

Regards,
Vlad