DSQL node classes

[Dmitry Yemanov]

All,

We currently have 14K+ lines in DdlNodes.epp and ExprNodes.epp. Do we
plan to keep the node classes grouped this way or may consider switching
to class-per-file layout (e.g. dsql/ddl/*, dsql/expr/*, etc)? I don't
speak about changing it completely right now, just what should be
preferred for the new features.

For example, the tablespaces branch already has TablespaceNodes.epp and
I need to know whether it should be moved to the existing DdlNodes heap
or may become a start for the new nodes layout.


Dmitry

[Vlad Khorsun]

пт, 17 жовт. 2025 р. о 11:57 Dmitry Yemanov <fire...@yandex.ru> пише:

All,

We currently have 14K+ lines in DdlNodes.epp and ExprNodes.epp. Do we
plan to keep the node classes grouped this way or may consider switching
to class-per-file layout (e.g. dsql/ddl/*, dsql/expr/*, etc)? I don't
speak about changing it completely right now, just what should be
preferred for the new features.

  Please,  not a "class-per-file". There should be better way to reach compromise between 

number of files and its sizes.  "class-per-file"is a worst possible way, as for me.

Regards,

Vlad

[Adriano dos Santos Fernandes]

We already discussed this (topic Split ExprNodes, BoolNodes and
StmtNodes) and the consensus was to split them per categories.

So I'm fine with TablespaceNodes.


Adriano

[Alex Peshkoff]

On 10/17/25 13:26, Adriano dos Santos Fernandes wrote:

> So I'm fine with TablespaceNodes.

+1