windows-2025, x64 build not building installer due to missing 32-bit fbclient.dll

[Mark Rotteveel]

The windows-2025, x64 build does not build an installer due to missing
32-bit fbclient.dll. Is that intentional?

Otherwise, objections if I include a similar step as in the Docker-based
Windows build to generate the 32-bit library?

Related, why do we have two separate builds for Windows (one using
Docker, the other using a Windows runner directly)?

Mark
--
Mark Rotteveel

[Adriano dos Santos Fernandes]

On 7/21/25 07:12, 'Mark Rotteveel' via firebird-devel wrote:

> Related, why do we have two separate builds for Windows (one using
> Docker, the other using a Windows runner directly)?
>

Feedback of non-docker build is fast.

Windows docker images cannot be put in public registry, so it need to be
created at each build.


Adriano

[Mark Rotteveel]

OK, but then why use the Docker-based build at all? Why isn't the
Windows 2025 runner sufficient?

Mark
--
Mark Rotteveel

[Adriano dos Santos Fernandes]

The official builds are the docker-based ones.

We can't control version of Visual Studio in the runner.


Adriano

[Dimitry Sibiryakov]

Adriano dos Santos Fernandes wrote 21.07.2025 13:05:
> We can't control version of Visual Studio in the runner.

It used to be the latest. But the real question is "why do you want to
control it?"

--
WBR, SD.

[Mark Rotteveel]

OK, so it's for the reproducibility of the build.

Mark
--
Mark Rotteveel

[Mark Rotteveel]

On 21/07/2025 12:12, 'Mark Rotteveel' via firebird-devel wrote:
> The windows-2025, x64 build does not build an installer due to missing
> 32-bit fbclient.dll. Is that intentional?
>
> Otherwise, objections if I include a similar step as in the Docker-based
> Windows build to generate the 32-bit library?

One possible objection I found myself is that it will increase the
runtime of that build, as it will do the full 32-bit build next to the
64-bit build, essentially duplicating the work of the (windows-2025,
x86) build.

Is that worth it?

Mark
--
Mark Rotteveel

[Dimitry Sibiryakov]

'Mark Rotteveel' via firebird-devel wrote 21.07.2025 14:53:
>
> One possible objection I found myself is that it will increase the runtime of
> that build, as it will do the full 32-bit build next to the 64-bit build,
> essentially duplicating the work of the (windows-2025, x86) build.

There is no need for a full build: CLIENT_ONLY parameter exists exactly for
this case.

--
WBR, SD.

[Mark Rotteveel]

OK, but that then raises the question why that doesn't seem to be used
in the other build (windows-docker-x64)

Mark
--
Mark Rotteveel