Issue 58 in feed-on-feeds: Sharing link does not work.

2 views
Skip to first unread message

codesite...@google.com

unread,
May 13, 2009, 9:14:14 AM5/13/09
to feed-on-fe...@googlegroups.com
Status: New
Owner: ----

New issue 58 by bas.janssen: Sharing link does not work.
http://code.google.com/p/feed-on-feeds/issues/detail?id=58

What steps will reproduce the problem?
1. With the plugin "sharing enabled" klick the link "not shared" next to an
item

What is the expected output? What do you see instead?
The link schould change to 'shared', but instead you get a blank page with
FALSE

What version of the product are you using? On what operating system?
0.5 (latest)

Please provide any additional information below.

Solution: in plugins/sharing.php

change the line:

return "<a href=\"$shared_link\" onclick=\"$shared_link\"><img
src=\"$shared_image\" width=\"12\" height=\"12\" border=\"0\"/></a> <a
href=\"$shared_link\">$shared_text</a> ";

with:

return "<a href=\"#\" onclick=\"$shared_link\"><img src=\"$shared_image\"
width=\"12\" height=\"12\" border=\"0\"/></a> <a href=\"#\"
onclick=\"$shared_link\">$shared_text</a> ";


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

codesite...@google.com

unread,
May 13, 2009, 9:32:27 AM5/13/09
to feed-on-fe...@googlegroups.com

Comment #1 on issue 58 by bas.janssen: Sharing link does not work.
http://code.google.com/p/feed-on-feeds/issues/detail?id=58

sorry, correct code should be:

return "<a href=\"#\" onclick=\"$shared_link; return false;\"><img


src=\"$shared_image\" width=\"12\" height=\"12\" border=\"0\"/></a> <a
href=\"#\"

onclick=\"$shared_link; return false;\">$shared_text</a> ";

(so page doesn't refresh)

Reply all
Reply to author
Forward
0 new messages