Issue w/ extended arrays
10 views
Skip to first unread message
Sean Coyne
Jul 16, 2010, 10:31:56 AM7/16/10
to farcry-dev
With the recent changes to how the refObjects table is used extended
array tables (farcry.core.packages.types.arrayTable) no longer get
placed into refObjects causing issues looking up the typename. This
can be seen in the FarCry CMS Handpicked rule. When you go to the
second wizard step to select the webskin, it cannot find the type so
it throws an error.
This can be fixed by changing bRefObjects="false" to "true".
Is there another reason why extended arrays should NOT be going into
refObjects??
Filed as FC-2323
https://farcry.jira.com/browse/FC-2323
array tables (farcry.core.packages.types.arrayTable) no longer get
placed into refObjects causing issues looking up the typename. This
can be seen in the FarCry CMS Handpicked rule. When you go to the
second wizard step to select the webskin, it cannot find the type so
it throws an error.
This can be fixed by changing bRefObjects="false" to "true".
Is there another reason why extended arrays should NOT be going into
refObjects??
Filed as FC-2323
https://farcry.jira.com/browse/FC-2323
Blair McKenzie
Jul 16, 2010, 5:47:44 PM7/16/10
to farcr...@googlegroups.com
Now that is weird. Thanks, Sean, I'll have a look ASAP.
Blair
Blair
--
You received this message cos you are subscribed to "farcry-dev" Google group.
To post, email: farcr...@googlegroups.com
To unsubscribe, email: farcry-dev+...@googlegroups.com
For more options: http://groups.google.com/group/farcry-dev
--------------------------------
Follow us on Twitter: http://twitter.com/farcry
Jeff Coughlin
Jul 16, 2010, 6:16:13 PM7/16/10
to farcr...@googlegroups.com
I can see what you were doing which makes sense (https://farcry.jira.com/source/changelog/FC?cs=11165)
But, yeah. That one change in arrayTable.cfc (setting bRefObjects="false") breaks a lot of extended array use we have. Sure we can manually turn it on for all extended array components, but is there a specific reason for disabling that? Just wondering. Although it breaks backwards compatibility, if there is a reason to have it there then we'll just have to live with it.
--
Jeff Coughlin
Web Application Developer
http://jeffcoughlin.com
Blair McKenzie
Jul 16, 2010, 6:18:53 PM7/16/10
to farcr...@googlegroups.com
I'm going to try to track down the places where arrays depend on the refObjects table. If they're simple to factor away I'll do that, otherwise it will be better to re-enable refObjects.
Sean Coyne
Jul 16, 2010, 6:20:54 PM7/16/10
to farcry-dev
start w/ ruleHandpicked_aObjects/update.cfm in the CMS plugin :)
On Jul 16, 6:18 pm, Blair McKenzie <shi...@gmail.com> wrote:
> I'm going to try to track down the places where arrays depend on the
> refObjects table. If they're simple to factor away I'll do that, otherwise
> it will be better to re-enable refObjects.
>
On Jul 16, 6:18 pm, Blair McKenzie <shi...@gmail.com> wrote:
> I'm going to try to track down the places where arrays depend on the
> refObjects table. If they're simple to factor away I'll do that, otherwise
> it will be better to re-enable refObjects.
>
> On Sat, Jul 17, 2010 at 8:16 AM, Jeff Coughlin <j...@jeffcoughlin.com>wrote:
>
>
>
> > I can see what you were doing which makes sense (
> >https://farcry.jira.com/source/changelog/FC?cs=11165)
>
> > But, yeah. That one change in arrayTable.cfc (setting bRefObjects="false")
> > breaks a lot of extended array use we have. Sure we can manually turn it on
> > for all extended array components, but is there a specific reason for
> > disabling that? Just wondering. Although it breaks backwards
> > compatibility, if there is a reason to have it there then we'll just have to
> > live with it.
>
> > --
> > Jeff Coughlin
> > Web Application Developer
> >http://jeffcoughlin.com
>
> > On Jul 16, 2010, at 5:47 PM, Blair McKenzie wrote:
>
> > > Now that is weird. Thanks, Sean, I'll have a look ASAP.
>
> > > Blair
>
> > > On Sat, Jul 17, 2010 at 12:31 AM, Sean Coyne <coyne.s...@gmail.com>
>
>
>
> > I can see what you were doing which makes sense (
> >https://farcry.jira.com/source/changelog/FC?cs=11165)
>
> > But, yeah. That one change in arrayTable.cfc (setting bRefObjects="false")
> > breaks a lot of extended array use we have. Sure we can manually turn it on
> > for all extended array components, but is there a specific reason for
> > disabling that? Just wondering. Although it breaks backwards
> > compatibility, if there is a reason to have it there then we'll just have to
> > live with it.
>
> > --
> > Jeff Coughlin
> > Web Application Developer
> >http://jeffcoughlin.com
>
> > On Jul 16, 2010, at 5:47 PM, Blair McKenzie wrote:
>
> > > Now that is weird. Thanks, Sean, I'll have a look ASAP.
>
> > > Blair
>
> > wrote:
> > > With the recent changes to how the refObjects table is used extended
> > > array tables (farcry.core.packages.types.arrayTable) no longer get
> > > placed into refObjects causing issues looking up the typename. This
> > > can be seen in the FarCry CMS Handpicked rule. When you go to the
> > > second wizard step to select the webskin, it cannot find the type so
> > > it throws an error.
>
> > > This can be fixed by changing bRefObjects="false" to "true".
>
> > > Is there another reason why extended arrays should NOT be going into
> > > refObjects??
>
> > > Filed as FC-2323
>
> > >https://farcry.jira.com/browse/FC-2323
>
> > > --
> > > You received this message cos you are subscribed to "farcry-dev" Google
> > group.
> > > To post, email: farcr...@googlegroups.com
> > > To unsubscribe, email: farcry-dev+...@googlegroups.com<farcry-dev%2Bunsubscribe@googlegrou ps.com>
> > > With the recent changes to how the refObjects table is used extended
> > > array tables (farcry.core.packages.types.arrayTable) no longer get
> > > placed into refObjects causing issues looking up the typename. This
> > > can be seen in the FarCry CMS Handpicked rule. When you go to the
> > > second wizard step to select the webskin, it cannot find the type so
> > > it throws an error.
>
> > > This can be fixed by changing bRefObjects="false" to "true".
>
> > > Is there another reason why extended arrays should NOT be going into
> > > refObjects??
>
> > > Filed as FC-2323
>
> > >https://farcry.jira.com/browse/FC-2323
>
> > > --
> > > You received this message cos you are subscribed to "farcry-dev" Google
> > group.
> > > To post, email: farcr...@googlegroups.com
> > > For more options:http://groups.google.com/group/farcry-dev
> > > --------------------------------
> > > Follow us on Twitter:http://twitter.com/farcry
>
> > > --
> > > You received this message cos you are subscribed to "farcry-dev" Google
> > group.
> > > To post, email: farcr...@googlegroups.com
> > > To unsubscribe, email: farcry-dev+...@googlegroups.com<farcry-dev%2Bunsubscribe@googlegrou ps.com>
> > > --------------------------------
> > > Follow us on Twitter:http://twitter.com/farcry
>
> > > --
> > > You received this message cos you are subscribed to "farcry-dev" Google
> > group.
> > > To post, email: farcr...@googlegroups.com
> > > For more options:http://groups.google.com/group/farcry-dev
> > > --------------------------------
> > > Follow us on Twitter:http://twitter.com/farcry
>
> > --
> > You received this message cos you are subscribed to "farcry-dev" Google
> > group.
> > To post, email: farcr...@googlegroups.com
> > To unsubscribe, email: farcry-dev+...@googlegroups.com<farcry-dev%2Bunsubscribe@googlegrou ps.com>
> > > --------------------------------
> > > Follow us on Twitter:http://twitter.com/farcry
>
> > --
> > You received this message cos you are subscribed to "farcry-dev" Google
> > group.
> > To post, email: farcr...@googlegroups.com
Geoffrey Bowers
Jul 16, 2010, 10:23:57 PM7/16/10
to farcr...@googlegroups.com
On 17/07/2010, at 8:16 AM, Jeff Coughlin wrote:
> But, yeah. That one change in arrayTable.cfc (setting bRefObjects="false") breaks a lot of extended array use we have. Sure we can manually turn it on for all extended array components, but is there a specific reason for disabling that? Just wondering. Although it breaks backwards compatibility, if there is a reason to have it there then we'll just have to live with it.
> But, yeah. That one change in arrayTable.cfc (setting bRefObjects="false") breaks a lot of extended array use we have. Sure we can manually turn it on for all extended array components, but is there a specific reason for disabling that? Just wondering. Although it breaks backwards compatibility, if there is a reason to have it there then we'll just have to live with it.
Every time FarCry doesn't know the typename it has to do a findType() look up on refObjects. This can be avoided by providing the typename in your code, assuming you have it available. We really should know the typename in almost all internal core operations, so we've been trying to remove core content types (plus rules etc) dependence on refobjects to improve overall performance.
We've been implementing these progressive performance enhancements ever since 6.0 was released. Note these are supposed to be transparent to users and should not be causing compatibility issues in the maintenance branch. Apologies for the inconvenience -- it looks like we've over stepped the mark on this recent revision and we should have a patch out shortly.
Regards,
-- geoff
http://www.daemon.com.au/
Phillip R
Jul 23, 2010, 7:03:22 AM7/23/10
to farcry-dev
Great, missed this, thought I was going nuts :) Look forward to the
patch.
Phil
patch.
Phil
AJ Mercer
Jul 25, 2010, 2:19:51 AM7/25/10
to farcr...@googlegroups.com
I have been crash-n-burning burning my way through this one :-(
It seems to me this is an old-school rule - maybe it could do with a complete rewrite??
anyhoo - my changes so far to update.cfm
<!--- AJM: added typename ---><ft:object typename="#stWizard.data[stobj.objectid].aObjects[i].typename#" objectid="#stWizard.data[stobj.objectid].aObjects[i].objectid#" lfields="webskin" r_stFields="stFields" />
and
<tr>
<td style="padding:10px;">#teaserHTML#</td>
<td style="padding:10px;">
<cfif IsDefined('stFields.webskin.htm')>
#stFields.webskin.html#
<cfelseif IsDefined('stFields.displayMethod.html')>
#stFields.displayMethod.html#
<cfelse>
no display tempate
</cfif>
</td>
</tr>
This has got me to the point where I can save the rule
but now working on execute.cfm
Also, a couple of bugs for 606 I have submitted
--
You received this message cos you are subscribed to "farcry-dev" Google group.
To post, email: farcr...@googlegroups.com
To unsubscribe, email: farcry-dev+...@googlegroups.com
For more options: http://groups.google.com/group/farcry-dev
--------------------------------
Follow us on Twitter: http://twitter.com/farcry
Phillip R
Jul 25, 2010, 8:08:33 AM7/25/10
to farcry-dev
Thanks AJ, I'll try that fix in the morning.
I've always felt this rule needs to be at the top of the list and in
bold. It truly is the ultimate rule.
I remember someone (Geoff?) referring to it as the 'almighty'
handpicked rule. Maybe we should change it out of utility :)
To my knowledge it's broken in 6.0.4 and 6.0.5.
> <https://farcry.jira.com/browse/FC-2326>https://farcry.jira.com/browse/FC-2327
> <https://farcry.jira.com/browse/FC-2327>
> > To unsubscribe, email: farcry-dev+...@googlegroups.com<farcry-dev%2Bunsu...@googlegroups.com>
> <webonix:net strength="Industrial" /> <http://webonix.net> | <webonix:org
> community="Open" /> <http://webonix.org>http://twitter.com/webonix
I've always felt this rule needs to be at the top of the list and in
bold. It truly is the ultimate rule.
I remember someone (Geoff?) referring to it as the 'almighty'
handpicked rule. Maybe we should change it out of utility :)
To my knowledge it's broken in 6.0.4 and 6.0.5.
> <https://farcry.jira.com/browse/FC-2327>
> > For more options:http://groups.google.com/group/farcry-dev
> > --------------------------------
> > Follow us on Twitter:http://twitter.com/farcry
>
> --
>
> *AJ Mercer*
> > --------------------------------
> > Follow us on Twitter:http://twitter.com/farcry
>
> --
>
> <webonix:net strength="Industrial" /> <http://webonix.net> | <webonix:org
> community="Open" /> <http://webonix.org>http://twitter.com/webonix
Sean Coyne
Jul 27, 2010, 7:34:31 AM7/27/10
to farcry-dev
All that needs to be done is add bRefObjects="true" to the
ruleHandpicked_aObjects.cfc in the packages folder of the CMS plugin.
> > > To unsubscribe, email: farcry-dev+...@googlegroups.com<farcry-dev%2Bunsubscribe@googlegrou ps.com>
ruleHandpicked_aObjects.cfc in the packages folder of the CMS plugin.
Knut
Aug 24, 2010, 7:15:26 PM8/24/10
to farcry-dev
It would be nice, if the fix that Sean posted (bRefObjects="true") for
the still none working "handpicked Rule" would be integrated into the
p600 SVN.
...
<cfcomponent extends="farcry.core.packages.types.arrayTable"
displayname="Handpicked Rule Extended Array Table" hint="Handpicked
Rule Extended Array Table" bObjectBroker="true" bRefObjects="true">
....
This works !!!
On 27 Jul., 13:34, Sean Coyne <coyne.s...@gmail.com> wrote:
> All that needs to be done is add bRefObjects="true" to the
> ruleHandpicked_aObjects.cfc in the packages folder of the CMS plugin.
>
> On Jul 25, 8:08 am, Phillip R <phill...@webolution.co.nz> wrote:
>
> > Thanks AJ, I'll try that fix in the morning.
> > I've always felt thisruleneeds to be at the top of the list and in
the still none working "handpicked Rule" would be integrated into the
p600 SVN.
...
<cfcomponent extends="farcry.core.packages.types.arrayTable"
displayname="Handpicked Rule Extended Array Table" hint="Handpicked
Rule Extended Array Table" bObjectBroker="true" bRefObjects="true">
....
This works !!!
On 27 Jul., 13:34, Sean Coyne <coyne.s...@gmail.com> wrote:
> All that needs to be done is add bRefObjects="true" to the
> ruleHandpicked_aObjects.cfc in the packages folder of the CMS plugin.
>
> On Jul 25, 8:08 am, Phillip R <phill...@webolution.co.nz> wrote:
>
> > Thanks AJ, I'll try that fix in the morning.
> > bold. It truly is the ultimaterule.
> > I remember someone (Geoff?) referring to it as the 'almighty'
> >handpickedrule. Maybe we should change it out of utility :)
> > I remember someone (Geoff?) referring to it as the 'almighty'
> > To my knowledge it's broken in 6.0.4 and 6.0.5.
>
> > On Jul 25, 6:19 pm, AJ Mercer <ajmer...@gmail.com> wrote:
>
> > > I have been crash-n-burning burning my way through this one :-(
>
> > > It seems to me this is an old-schoolrule- maybe it could do with a
>
> > On Jul 25, 6:19 pm, AJ Mercer <ajmer...@gmail.com> wrote:
>
> > > I have been crash-n-burning burning my way through this one :-(
>
Blair McKenzie
Aug 24, 2010, 7:28:54 PM8/24/10
to farcr...@googlegroups.com
Thanks for reminding me Knut. I reverted the change to arrayTable in core. I believe it will be released in 6.0.6. Your fix is a good work around if you can't go to the branch head.
Knut
Aug 26, 2010, 10:36:17 AM8/26/10
to farcry-dev
Hi Blair,
thanks for integrating the fix !!!
Regards .. Knut
On 25 Aug., 01:28, Blair McKenzie <shi...@gmail.com> wrote:
> Thanks for reminding me Knut. I reverted the change to arrayTable in core. I
> believe it will be released in 6.0.6. Your fix is a good work around if you
> can't go to the branch head.
>
> > > > > > To unsubscribe, email: farcry-dev+...@googlegroups.com<farcry-dev%2Bunsu...@googlegroups.com>
thanks for integrating the fix !!!
Regards .. Knut
On 25 Aug., 01:28, Blair McKenzie <shi...@gmail.com> wrote:
> Thanks for reminding me Knut. I reverted the change to arrayTable in core. I
> believe it will be released in 6.0.6. Your fix is a good work around if you
> can't go to the branch head.
>
> > <farcry-dev%2Bunsubscribe@googlegrou ps.com>
> > > > > > For more options:http://groups.google.com/group/farcry-dev
> > > > > > --------------------------------
> > > > > > Follow us on Twitter:http://twitter.com/farcry
>
> > > > > --
>
> > > > > *AJ Mercer*
> > > > > <webonix:net strength="Industrial" /> <http://webonix.net> |
> > <webonix:org
> > > > > community="Open" /> <http://webonix.org>http://twitter.com/webonix
>
> > --
> > You received this message cos you are subscribed to "farcry-dev" Google
> > group.
> > To post, email: farcr...@googlegroups.com
> > To unsubscribe, email: farcry-dev+...@googlegroups.com<farcry-dev%2Bunsu...@googlegroups.com>
> > > > > > For more options:http://groups.google.com/group/farcry-dev
> > > > > > --------------------------------
> > > > > > Follow us on Twitter:http://twitter.com/farcry
>
> > > > > --
>
> > > > > *AJ Mercer*
> > > > > <webonix:net strength="Industrial" /> <http://webonix.net> |
> > <webonix:org
> > > > > community="Open" /> <http://webonix.org>http://twitter.com/webonix
>
> > --
> > You received this message cos you are subscribed to "farcry-dev" Google
> > group.
> > To post, email: farcr...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages