[FarGroup/FarManager] master: Reduce spam in logs (75a62b6cc)

0 views
Skip to first unread message

farg...@farmanager.com

unread,
Nov 10, 2025, 4:45:57 PM (6 days ago) Nov 10
to farco...@googlegroups.com
Repository : https://github.com/FarGroup/FarManager
On branch : master
Link : https://github.com/FarGroup/FarManager/commit/75a62b6ccf29250a8a55f753859d0fdcc940a42f

>---------------------------------------------------------------

commit 75a62b6ccf29250a8a55f753859d0fdcc940a42f
Author: Alex Alabuzhev <alab...@gmail.com>
Date: Mon Nov 10 21:39:17 2025 +0000

Reduce spam in logs


>---------------------------------------------------------------

75a62b6ccf29250a8a55f753859d0fdcc940a42f
far/console.cpp | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/far/console.cpp b/far/console.cpp
index 67713134b..5deb9ea46 100644
--- a/far/console.cpp
+++ b/far/console.cpp
@@ -999,7 +999,12 @@ protected:
wchar_t Buffer[KL_NAMELENGTH];
if (!imports.GetConsoleKeyboardLayoutNameW(Buffer))
{
- LOGWARNING(L"GetConsoleKeyboardLayoutNameW(): {}"sv, os::last_error());
+ // This API is unsupported and looks like they broke it in Windows 10 entirely.
+ // Moreover, the error code is also broken (see microsoft/terminal#14479),
+ // FormatMessage does not recognize it and produces another error.
+ // All this just spams the log endlessly, so no point in even trying for now.
+
+ // LOGWARNING(L"GetConsoleKeyboardLayoutNameW(): {}"sv, os::last_error());
return {};
}



Reply all
Reply to author
Forward
0 new messages