[FarGroup/FarManager] master: Warnings (3280799fe)

[farg...@farmanager.com]

Repository : https://github.com/FarGroup/FarManager
On branch : master
Link : https://github.com/FarGroup/FarManager/commit/3280799fecb08c74e17bc254d00020f56c2bbd0b

>---------------------------------------------------------------

commit 3280799fecb08c74e17bc254d00020f56c2bbd0b
Author: Alex Alabuzhev <alab...@gmail.com>
Date: Tue Jun 16 23:16:36 2026 +0100

Warnings


>---------------------------------------------------------------

3280799fecb08c74e17bc254d00020f56c2bbd0b
far/disabled_warnings.hpp | 1 +
far/diskmenu.cpp | 13 ++++++++-----
far/editor.cpp | 1 -
far/exception_handler.cpp | 1 +
far/setattr.cpp | 11 +++++++----
far/vmenu.cpp | 2 +-
6 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/far/disabled_warnings.hpp b/far/disabled_warnings.hpp
index a67c74ec8..7538d4f33 100644
--- a/far/disabled_warnings.hpp
+++ b/far/disabled_warnings.hpp
@@ -133,6 +133,7 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#pragma clang diagnostic ignored "-Wc++98-compat"
#pragma clang diagnostic ignored "-Wc++98-compat-pedantic"
#pragma clang diagnostic ignored "-Wc++20-compat"
+#pragma clang diagnostic ignored "-Wc++20-extensions"
#pragma clang diagnostic ignored "-Wconversion"
#pragma clang diagnostic ignored "-Wcovered-switch-default"
#pragma clang diagnostic ignored "-Wctad-maybe-unsupported"
diff --git a/far/diskmenu.cpp b/far/diskmenu.cpp
index ed6d5bd01..88dce57d0 100644
--- a/far/diskmenu.cpp
+++ b/far/diskmenu.cpp
@@ -84,12 +84,15 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

//----------------------------------------------------------------------------

-enum class state
+namespace
{
- unknown,
- yes,
- no
-};
+ enum class state
+ {
+ unknown,
+ yes,
+ no
+ };
+}

template<size_t N>
class optional_bitset
diff --git a/far/editor.cpp b/far/editor.cpp
index d33efef89..eea56143c 100644
--- a/far/editor.cpp
+++ b/far/editor.cpp
@@ -3634,7 +3634,6 @@ namespace

private:
const short m_LineNumColumnMaxWidth{};
- static constexpr short m_FoundPosColumnMaxWidth{ 10 }; // Enough?
int m_MaxLineNum{};
int m_MaxFoundPos{};
int m_LastSeenLine{ -1 };
diff --git a/far/exception_handler.cpp b/far/exception_handler.cpp
index 510ef4223..70c10cda4 100644
--- a/far/exception_handler.cpp
+++ b/far/exception_handler.cpp
@@ -2423,6 +2423,7 @@ constexpr auto real_wassert = _wassert;

WARNING_PUSH()
WARNING_DISABLE_MSC(4273) // 'function': inconsistent dll linkage
+WARNING_DISABLE_CLANG("-Wmissing-prototypes")
void far_assert(wchar_t const* const Message, wchar_t const* const File, unsigned const Line)
{
switch (assert_handler_impl(Message, { encoding::utf8::get_bytes(File).c_str(), "assert", Line }))
diff --git a/far/setattr.cpp b/far/setattr.cpp
index 1f935871d..3433fa10f 100644
--- a/far/setattr.cpp
+++ b/far/setattr.cpp
@@ -696,11 +696,14 @@ public:
}
};

-struct state
+namespace
{
- string const& Owner;
- os::fs::find_data const& FindData;
-};
+ struct state
+ {
+ string const& Owner;
+ os::fs::find_data const& FindData;
+ };
+}

static bool process_single_file(
const string& Computer,
diff --git a/far/vmenu.cpp b/far/vmenu.cpp
index 135e06ecd..b75cbe59e 100644
--- a/far/vmenu.cpp
+++ b/far/vmenu.cpp
@@ -3701,7 +3701,7 @@ TEST_CASE("markup.highlight")
const auto Markup{ markup_highlight(TestDataPoint.Text, TestDataPoint.Highlight) };
REQUIRE(Markup.size() == TestDataPoint.Markup.size());

- for (const auto [Actual, Expected] : zip(Markup, TestDataPoint.Markup))
+ for (const auto& [Actual, Expected]: zip(Markup, TestDataPoint.Markup))
{
REQUIRE(Check(TestDataPoint.Text, Actual, Expected));
}