Support for jdk 1.8

[Brian C]

Faban only supports jdk versions 1.5 through 1.7.  For running with JDK 1.8, we have made the following modification to faban/harness/faban/master/bin/startup.sh:

$ diff -c -C 8 startup.sh startup.sh.orig
*** startup.sh  2014-05-14 02:26:11.000000000 -0400
--- startup.sh.orig     2010-05-10 12:13:58.000000000 -0400
***************
*** 20,36 ****
 
  JAVA_VERSION=`echo $JAVA_VER_STRING | \
                 awk '{ print substr($3, 2, length($3) - 2)}'`
 
  case $JAVA_VERSION in
      1.5*);;
      1.6*);;
      1.7*);;
-     1.8*);;
      *) echo "Java version is ${JAVA_VERSION}. Faban needs 1.5 or later." >&2
         echo "Please install the appropriate JDK and set JAVA_HOME accordingly." >&2
         exit 1;;
  esac
 
  # resolve links - $0 may be a softlink
  PRGDIR=`dirname $0`
 
--- 20,35 ----

Can this change be included into the next Faban release.  We are currently modifying Faban in this way to release SPECjEnterprise submissions using JDK 1.8.  Even better would be to change this in a way that it will support all versions of 1.5 or higher.

Thanks,

-Brian Chesebro

Oracle Corporation

[Doug Tollefson]

+1

[Shanti Subramanyam (gmail)]

If this is running successfully for you, we can make this change. I believe the caution around versions was introduced due to the bundling of tomcat.

Please file a ticket on github. A pull request is also appreicated.

Shanti

On Wed, Feb 18, 2015 at 2:18 PM, Doug Tollefson <juggl...@gmail.com> wrote:

+1

 Even better would be to change this in a way that it will support all versions of 1.5 or higher.

--
You received this message because you are subscribed to the Google Groups "faban-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to faban-users...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Brian C]

Thank you Shanti,

I have filed a ticket on github, and also created the pull request:

issue#82: https://github.com/akara/faban/issues/82

pull request: https://github.com/akara/faban/pull/83/files

diff: https://github.com/akara/faban/pull/83.diff

-Brian

--
You received this message because you are subscribed to a topic in the Google Groups "faban-users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/faban-users/8mp6DNTEIyc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to faban-users...@googlegroups.com.