Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
kern/51553: src/sys/altq/altq_jobs.c: 2 * pointless local variables ?
1 view
Skip to first unread message
d...@netbsd.org
Oct 11, 2016, 5:23:06 PM10/11/16
to kern-bu...@netbsd.org, gnats...@netbsd.org, netbs...@netbsd.org
>Number: 51553
>Category: kern
>Synopsis: src/sys/altq/altq_jobs.c: 2 * pointless local variables ?
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Oct 11 15:50:00 +0000 2016
>Originator: David Binderman
>Release: cvs-20161011
>Organization:
>Environment:
>Description:
[src/sys/altq/altq_jobs.c:1573]: (style) Variable 'backlogged_classes' is modified but its new value is never used.
[src/sys/altq/altq_jobs.c:1714]: (style) Variable 'backlogged_classes' is modified but its new value is never used.
$ fgrep backlogged_classes src/sys/altq/altq_jobs.c
int active_classes, backlogged_classes;
backlogged_classes = 0;
backlogged_classes++;
int i, active_classes, backlogged_classes;
backlogged_classes = 0;
backlogged_classes ++;
$
Suggest delete local variables "backlogged_classes". They aren't used anywhere.
>How-To-Repeat:
>Fix:
>Category: kern
>Synopsis: src/sys/altq/altq_jobs.c: 2 * pointless local variables ?
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Oct 11 15:50:00 +0000 2016
>Originator: David Binderman
>Release: cvs-20161011
>Organization:
>Environment:
>Description:
[src/sys/altq/altq_jobs.c:1573]: (style) Variable 'backlogged_classes' is modified but its new value is never used.
[src/sys/altq/altq_jobs.c:1714]: (style) Variable 'backlogged_classes' is modified but its new value is never used.
$ fgrep backlogged_classes src/sys/altq/altq_jobs.c
int active_classes, backlogged_classes;
backlogged_classes = 0;
backlogged_classes++;
int i, active_classes, backlogged_classes;
backlogged_classes = 0;
backlogged_classes ++;
$
Suggest delete local variables "backlogged_classes". They aren't used anywhere.
>How-To-Repeat:
>Fix:
0 new messages