Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

PR/49636 CVS commit: src/sys/kern

1 view
Skip to first unread message

David A. Holland

unread,
Oct 9, 2016, 9:25:07 PM10/9/16
to kern-bu...@netbsd.org, gnats...@netbsd.org, netbs...@netbsd.org, henning....@t-online.de
The following reply was made to PR kern/49636; it has been noted by GNATS.

From: "David A. Holland" <dhol...@netbsd.org>
To: gnats...@gnats.NetBSD.org
Cc:
Subject: PR/49636 CVS commit: src/sys/kern
Date: Mon, 10 Oct 2016 01:22:08 +0000

Module Name: src
Committed By: dholland
Date: Mon Oct 10 01:22:08 UTC 2016

Modified Files:
src/sys/kern: uipc_socket.c

Log Message:
PR 49636 Henning Petersen: use "0L" to return 0 from a function returning
long, and test its returned value against "0L" instead of "0".

This is not especially necessary, but it's also harmless.


To generate a diff of this commit:
cvs rdiff -u -r1.249 -r1.250 src/sys/kern/uipc_socket.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

David A. Holland

unread,
Oct 9, 2016, 9:25:15 PM10/9/16
to kern-bu...@netbsd.org, gnats...@netbsd.org, netbs...@netbsd.org, henning....@t-online.de
The following reply was made to PR kern/49636; it has been noted by GNATS.

From: "David A. Holland" <dhol...@netbsd.org>
To: gnats...@gnats.NetBSD.org
Cc:
Subject: PR/49636 CVS commit: src/sys/kern
Date: Mon, 10 Oct 2016 01:22:51 +0000

Module Name: src
Committed By: dholland
Date: Mon Oct 10 01:22:51 UTC 2016

Modified Files:
src/sys/kern: uipc_socket.c

Log Message:
foo & ~bar, not foo &~ bar. From Henning Petersen in PR 49636.


To generate a diff of this commit:
cvs rdiff -u -r1.250 -r1.251 src/sys/kern/uipc_socket.c

Valeriy E. Ushakov

unread,
Oct 13, 2016, 3:15:10 PM10/13/16
to kern-bu...@netbsd.org, gnats...@netbsd.org, netbs...@netbsd.org, henning....@t-online.de
The following reply was made to PR kern/49636; it has been noted by GNATS.

From: "Valeriy E. Ushakov" <u...@netbsd.org>
To: gnats...@gnats.NetBSD.org
Cc:
Subject: PR/49636 CVS commit: src/sys/kern
Date: Thu, 13 Oct 2016 19:10:23 +0000

Module Name: src
Committed By: uwe
Date: Thu Oct 13 19:10:23 UTC 2016

Modified Files:
src/sys/kern: uipc_socket.c

Log Message:
Revert to revision 1.249 to undo changes from PR 49636.

Marking up some zeroes with a type suffix, while not marking others in
the very same function does nothing but places cognitive burden on the
reader.

Spelling "clear bits" as "&~" is actually not uncommon (and some say
is more readable).


To generate a diff of this commit:
cvs rdiff -u -r1.251 -r1.252 src/sys/kern/uipc_socket.c
0 new messages