kern/48112: patch to support Sitecom N300 usb wifi adapter (urtwn)

[kue...@gmx.de]

>Number: 48112
>Category: kern
>Synopsis: patch to support Sitecom N300 usb wifi adapter (urtwn)
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: kern-bug-people
>State: open
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sat Aug 10 17:35:00 +0000 2013
>Originator: Kai-Uwe Eckhardt
>Release: 6.99.23 amd64
>Organization:
>Environment:
>Description:
The usb wifi adapter SITECOM N300 (WLA-2102) is not supported yet.
It is recognized as a REALTEK device and looking up the vendor and
product 0x0df6:0070 revealed that it should work with the urtwn driver
but the product code is not known to urtwn.
>How-To-Repeat:

>Fix:
With the following patches it works fine using WPA2. The dmesg:

urtwn0 at uhub3 port 1
urtwn0: Realtek 802.11n WLAN Adapter, rev 2.00/2.00, addr 3
urtwn0: MAC/BB RTL8192CU, RF 6052 2T2R, address 00:0c:f6:fe:56:77
urtwn0: 1 rx pipe, 2 tx pipes
urtwn0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps
urtwn0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps


--- usbdevs.orig 2013-08-10 19:01:29.000000000 +0200
+++ usbdevs 2013-08-10 19:01:25.000000000 +0200
@@ -2907,6 +2907,7 @@
product SITECOMEU RTL8192CU 0x0061 RTL8192CU
product SITECOMEU WLA5000 0x0062 WLA-5000
product SITECOMEU LN028 0x061c LN-028
+product SITECOMEU RTL8192CUR2 0x0070 RTL8192CU rev 2/2
product SITECOMEU WL113 0x9071 WL-113
product SITECOMEU ZD1211B 0x9075 ZD1211B
product SITECOMEU WL172 0x90ac WL-172

--- if_urtwn.c.orig 2013-08-10 19:01:42.000000000 +0200
+++ if_urtwn.c 2013-08-10 19:01:46.000000000 +0200
@@ -149,6 +149,7 @@
{ USB_VENDOR_SITECOMEU, USB_PRODUCT_SITECOMEU_RTL8188CU },
{ USB_VENDOR_SITECOMEU, USB_PRODUCT_SITECOMEU_RTL8188CU_2 },
{ USB_VENDOR_SITECOMEU, USB_PRODUCT_SITECOMEU_RTL8192CU },
+ { USB_VENDOR_SITECOMEU, USB_PRODUCT_SITECOMEU_RTL8192CUR2 },
{ USB_VENDOR_TRENDNET, USB_PRODUCT_TRENDNET_RTL8188CU },
{ USB_VENDOR_TRENDNET, USB_PRODUCT_TRENDNET_RTL8192CU },
{ USB_VENDOR_ZYXEL, USB_PRODUCT_ZYXEL_RTL8192CU }

[Kai-Uwe Eckhardt]

The following reply was made to PR kern/48112; it has been noted by GNATS.

From: "Kai-Uwe Eckhardt" <kue...@gmx.de>
To: gnats...@NetBSD.org
Cc: TKlausner <w...@NetBSD.org>
Subject: Aw: Re: kern/48112: patch to support Sitecom N300 usb wifi adapter
(urtwn)

Date: Sat, 10 Aug 2013 22:23:07 +0200 (CEST)

If the patch is accepted, the man page should be updated as well:

--- urtwn.4.orig 2013-08-10 22:05:19.000000000 +0200
+++ urtwn.4 2013-08-10 22:15:04.000000000 +0200
@@ -15,7 +15,7 @@
.\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
.\"
-.Dd July 31, 2013
+.Dd August 10, 2013
.Dt URTWN 4
.Os
.Sh NAME
@@ -107,6 +107,7 @@
.It Planex GW-USWExtreme
.It POWCHIP POW-N18
.It Sitecom WL-365
+.It Sitecom N300 USB (WLA-2102 v1)
.It Solwise NET-WL-UMD-606N
.It TRENDnet TEW-648UBM
.El

[jne...@netbsd.org]

Synopsis: patch to support Sitecom N300 usb wifi adapter (urtwn)

Responsible-Changed-From-To: kern-bug-people->jnemeth
Responsible-Changed-By: jne...@NetBSD.org
Responsible-Changed-When: Sat, 10 Aug 2013 21:17:31 +0000
Responsible-Changed-Why:
I'm working on it.


State-Changed-From-To: open->analyzed
State-Changed-By: jne...@NetBSD.org
State-Changed-When: Sat, 10 Aug 2013 21:17:31 +0000
State-Changed-Why:
Patch applied, but it should be pulled up.

[John Nemeth]

The following reply was made to PR kern/48112; it has been noted by GNATS.

From: "John Nemeth" <jne...@netbsd.org>
To: gnats...@gnats.NetBSD.org
Cc:
Subject: PR/48112 CVS commit: src/sys/dev/usb
Date: Sat, 10 Aug 2013 21:15:26 +0000

Module Name: src
Committed By: jnemeth
Date: Sat Aug 10 21:15:26 UTC 2013

Modified Files:
src/sys/dev/usb: if_urtwn.c usbdevs usbdevs.h usbdevs_data.h

Log Message:
PR/48112 - Kai-Uwe Eckhardt -- add support for Sitecom N300 usb wifi adapter


To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 src/sys/dev/usb/if_urtwn.c
cvs rdiff -u -r1.651 -r1.652 src/sys/dev/usb/usbdevs
cvs rdiff -u -r1.643 -r1.644 src/sys/dev/usb/usbdevs.h
cvs rdiff -u -r1.644 -r1.645 src/sys/dev/usb/usbdevs_data.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

[John Nemeth]

The following reply was made to PR kern/48112; it has been noted by GNATS.

From: "John Nemeth" <jne...@netbsd.org>
To: gnats...@gnats.NetBSD.org
Cc:
Subject: PR/48112 CVS commit: src/share/man/man4
Date: Sat, 10 Aug 2013 21:32:07 +0000

Module Name: src
Committed By: jnemeth

Date: Sat Aug 10 21:32:07 UTC 2013

Modified Files:
src/share/man/man4: urtwn.4

Log Message:
PR/48112 - Kai-Uwe Eckhardt -- add support for Sitecom N300 USB WIFI adapter

To generate a diff of this commit:

cvs rdiff -u -r1.7 -r1.8 src/share/man/man4/urtwn.4

[Kai-Uwe Eckhardt]

The following reply was made to PR kern/48112; it has been noted by GNATS.

From: "Kai-Uwe Eckhardt" <kue...@gmx.de>
To: gnats...@NetBSD.org
Cc:

Subject: Re: kern/48112: patch to support Sitecom N300 usb wifi adapter
(urtwn)
Date: Sun, 11 Aug 2013 12:15:20 +0200 (CEST)

Thanks for the quick import. For reference the adapter is documented
on http://wikidevi.com/wiki/Sitecom_WLA-2102 . Since the driver
was originally written by Demian Bergamini for OpenBSD I will send him an
email to contribute back.

Thanks,

Kai-Uwe

[pgoy...@netbsd.org]

Synopsis: patch to support Sitecom N300 usb wifi adapter (urtwn)

State-Changed-From-To: analyzed->closed
State-Changed-By: pgoy...@NetBSD.org
State-Changed-When: Tue, 31 May 2016 07:06:19 +0000
State-Changed-Why:
Patch was committed by jnemeth@ on 10 Aug 2013 21:32:07 (including
man page update).

[jne...@netbsd.org]

Synopsis: patch to support Sitecom N300 usb wifi adapter (urtwn)

State-Changed-From-To: closed->analyzed
State-Changed-By: jne...@NetBSD.org
State-Changed-When: Tue, 31 May 2016 08:58:07 +0000
State-Changed-Why:
As the comment said when the state was originally changed to analyzed,
it should be pulled up. Don't be so hasty to close PRs!

[dhol...@netbsd.org]

Synopsis: patch to support Sitecom N300 usb wifi adapter (urtwn)

State-Changed-From-To: analyzed->needs-pullups
State-Changed-By: dhol...@NetBSD.org
State-Changed-When: Mon, 10 Oct 2016 01:00:37 +0000
State-Changed-Why:
use proper state for situation described

[David Holland]

The following reply was made to PR kern/48112; it has been noted by GNATS.

From: David Holland <dholla...@netbsd.org>
To: gnats...@netbsd.org
Cc:
Subject: Re: kern/48112 (patch to support Sitecom N300 usb wifi adapter
(urtwn))
Date: Mon, 10 Oct 2016 01:03:49 +0000

Also, there's a point where if pullups haven't been filed it's of
questionable utility to bother. The patch was committed more than
three years ago, before -7 was branched.

--
David A. Holland
dhol...@netbsd.org

[Kai-Uwe Eckhardt]

The following reply was made to PR kern/48112; it has been noted by GNATS.

From: "Kai-Uwe Eckhardt" <kue...@gmx.de>
To: gnats...@NetBSD.org
Cc:

Subject: Re: Re: kern/48112 (patch to support Sitecom N300 usb wifi adapter
(urtwn))
Date: Tue, 11 Oct 2016 17:16:34 +0200

> Also, there's a point where if pullups haven't been filed it's of
> questionable utility to bother. The patch was committed more than
> three years ago, before -7 was branched.

Is there anything I should provide as the originator of the PR ?
Works out of the box in 7.99.39.

Kai-Uwe