Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH 1/3] EDAC: Fix in e752x mc driver

0 views
Skip to first unread message

Doug Thompson

unread,
Dec 13, 2006, 8:24:53 PM12/13/06
to Andrew Morton
From: Mike Chan <mike...@google.com>

Diff against 2.6.19

This fix/change returns the offset into the page for
the ce/ue error, instead of just 0. The e752x dram controller reads
34:6 of the
linear address with the error.

Mike Chan

Signed-off-by: Mike Chan <mike...@google.com>
Signed-off-by: doug thompson <nor...@xmission.com>

---

e752x_edac.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)

Index: linux-2.6.19/drivers/edac/e752x_edac.c
===================================================================
--- linux-2.6.19.orig/drivers/edac/e752x_edac.c
+++ linux-2.6.19/drivers/edac/e752x_edac.c
@@ -285,8 +285,9 @@ static void do_process_ce(struct mem_ctl
if (!pvt->map_type)
row = 7 - row;

- edac_mc_handle_ce(mci, page, 0, sec1_syndrome, row, channel,
- "e752x CE");
+ /* e752x mc reads 34:6 of the DRAM linear address */
+ edac_mc_handle_ce(mci, page, offset_in_page(sec1_add << 4),
+ sec1_syndrome, row, channel, "e752x CE");
}

static inline void process_ce(struct mem_ctl_info *mci, u16 error_one,
@@ -319,8 +320,10 @@ static void do_process_ue(struct mem_ctl
((block_page >> 1) & 3) :
edac_mc_find_csrow_by_page(mci, block_page);

- edac_mc_handle_ue(mci, block_page, 0, row,
- "e752x UE from Read");
+ /* e752x mc reads 34:6 of the DRAM linear address */
+ edac_mc_handle_ue(mci, block_page,
+ offset_in_page(error_2b << 4),
+ row, "e752x UE from Read");
}
if (error_one & 0x0404) {
error_2b = scrb_add;
@@ -333,8 +336,10 @@ static void do_process_ue(struct mem_ctl
((block_page >> 1) & 3) :
edac_mc_find_csrow_by_page(mci, block_page);

- edac_mc_handle_ue(mci, block_page, 0, row,
- "e752x UE from Scruber");
+ /* e752x mc reads 34:6 of the DRAM linear address */
+ edac_mc_handle_ue(mci, block_page,
+ offset_in_page(error_2b << 4),
+ row, "e752x UE from Scruber");
}
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Alan

unread,
Dec 14, 2006, 5:46:02 AM12/14/06
to Doug Thompson
On Wed, 13 Dec 2006 17:17:45 -0800 (PST)
Doug Thompson <nor...@yahoo.com> wrote:

> From: Mike Chan <mike...@google.com>
>
> Diff against 2.6.19
>
> This fix/change returns the offset into the page for
> the ce/ue error, instead of just 0. The e752x dram controller reads
> 34:6 of the
> linear address with the error.
>
> Mike Chan
>
> Signed-off-by: Mike Chan <mike...@google.com>
> Signed-off-by: doug thompson <nor...@xmission.com>

Acked-by: Alan Cox <al...@redhat.com>

0 new messages