Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH 2/2] Be explicit about the Abbott product ids being product ids.

0 views
Skip to first unread message

Anders Hammarquist

unread,
Jun 18, 2013, 8:21:57 PM6/18/13
to gre...@linuxfoundation.org, linux-...@vger.kernel.org
Signed-off-by: Anders Hammarquist <i...@iko.pp.se>
---
drivers/usb/serial/ti_usb_3410_5052.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/serial/ti_usb_3410_5052.h b/drivers/usb/serial/ti_usb_3410_5052.h
index 4a2423e..ea8b273 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.h
+++ b/drivers/usb/serial/ti_usb_3410_5052.h
@@ -52,9 +52,9 @@

/* Abbott Diabetics vendor and product ids */
#define ABBOTT_VENDOR_ID 0x1a61
-#define ABBOTT_STEREO_PLUG_ID 0x3410
+#define ABBOTT_STEREO_PLUG_PRODUCT_ID 0x3410
#define ABBOTT_PRODUCT_ID ABBOTT_STEREO_PLUG_ID
-#define ABBOTT_STRIP_PORT_ID 0x3420
+#define ABBOTT_STRIP_PORT_PRODUCT_ID 0x3420

/* Commands */
#define TI_GET_VERSION 0x01
--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Greg KH

unread,
Jun 19, 2013, 6:52:15 PM6/19/13
to Anders Hammarquist, linux-...@vger.kernel.org
On Wed, Jun 19, 2013 at 01:58:49AM +0200, Anders Hammarquist wrote:
> Be explicit about the Abbott product ids being product ids.
>
> Signed-off-by: Anders Hammarquist <i...@iko.pp.se>
> ---
> drivers/usb/serial/ti_usb_3410_5052.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/ti_usb_3410_5052.h b/drivers/usb/serial/ti_usb_3410_5052.h
> index 4a2423e..ea8b273 100644
> --- a/drivers/usb/serial/ti_usb_3410_5052.h
> +++ b/drivers/usb/serial/ti_usb_3410_5052.h
> @@ -52,9 +52,9 @@
>
> /* Abbott Diabetics vendor and product ids */
> #define ABBOTT_VENDOR_ID 0x1a61
> -#define ABBOTT_STEREO_PLUG_ID 0x3410
> +#define ABBOTT_STEREO_PLUG_PRODUCT_ID 0x3410
> #define ABBOTT_PRODUCT_ID ABBOTT_STEREO_PLUG_ID

Can you just delete ABBOTT_PRODUCT_ID here, because if you ever use it,
you will get a build error, right?

I'll just take the first patch for now, please resend this one.

thanks,

greg k-h
0 new messages