Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.

22 views
Skip to first unread message

Richard W.M. Jones

unread,
Aug 20, 2012, 10:05:24 AM8/20/12
to linux-...@vger.kernel.org, pbon...@redhat.com, linux...@vger.kernel.org
From: "Richard W.M. Jones" <rjo...@redhat.com>

The sg struct is used without being initialized.

https://bugzilla.redhat.com/show_bug.cgi?id=847548

Signed-off-by: Richard W.M. Jones <rjo...@redhat.com>
---
drivers/scsi/virtio_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index c7030fb..8a66f83 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
struct scatterlist sg;
unsigned long flags;

- sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
+ sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));

spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);

--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Paolo Bonzini

unread,
Aug 20, 2012, 10:05:53 AM8/20/12
to Richard W.M. Jones, linux-...@vger.kernel.org, linux...@vger.kernel.org
Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:
> From: "Richard W.M. Jones" <rjo...@redhat.com>
>
> The sg struct is used without being initialized.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=847548
>
> Signed-off-by: Richard W.M. Jones <rjo...@redhat.com>
> ---
> drivers/scsi/virtio_scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> index c7030fb..8a66f83 100644
> --- a/drivers/scsi/virtio_scsi.c
> +++ b/drivers/scsi/virtio_scsi.c
> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
> struct scatterlist sg;
> unsigned long flags;
>
> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>
> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
>
>

Acked-by: Paolo Bonzini <pbon...@redhat.com>

Paolo

Paolo Bonzini

unread,
Oct 1, 2012, 9:13:16 AM10/1/12
to Richard W.M. Jones, linux-...@vger.kernel.org, linux...@vger.kernel.org
Il 20/08/2012 16:05, Paolo Bonzini ha scritto:
> Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:
>> From: "Richard W.M. Jones" <rjo...@redhat.com>
>>
>> The sg struct is used without being initialized.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=847548
>>
>> Signed-off-by: Richard W.M. Jones <rjo...@redhat.com>
>> ---
>> drivers/scsi/virtio_scsi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
>> index c7030fb..8a66f83 100644
>> --- a/drivers/scsi/virtio_scsi.c
>> +++ b/drivers/scsi/virtio_scsi.c
>> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
>> struct scatterlist sg;
>> unsigned long flags;
>>
>> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>>
>> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
>>
>>
>
> Acked-by: Paolo Bonzini <pbon...@redhat.com>
>
> Paolo
>

Ping, is this patch going into 3.7?

Richard W.M. Jones

unread,
Oct 1, 2012, 9:19:12 AM10/1/12
to Paolo Bonzini, linux-...@vger.kernel.org, linux...@vger.kernel.org
On Mon, Oct 01, 2012 at 03:13:01PM +0200, Paolo Bonzini wrote:
> Il 20/08/2012 16:05, Paolo Bonzini ha scritto:
> > Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:
> >> From: "Richard W.M. Jones" <rjo...@redhat.com>
> >>
> >> The sg struct is used without being initialized.
> >>
> >> https://bugzilla.redhat.com/show_bug.cgi?id=847548
> >>
> >> Signed-off-by: Richard W.M. Jones <rjo...@redhat.com>
> >> ---
> >> drivers/scsi/virtio_scsi.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> >> index c7030fb..8a66f83 100644
> >> --- a/drivers/scsi/virtio_scsi.c
> >> +++ b/drivers/scsi/virtio_scsi.c
> >> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
> >> struct scatterlist sg;
> >> unsigned long flags;
> >>
> >> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
> >> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
> >>
> >> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
> >>
> >>
> >
> > Acked-by: Paolo Bonzini <pbon...@redhat.com>
> >
> > Paolo
> >
>
> Ping, is this patch going into 3.7?

I was a bit surprised to see this wasn't upstream since it's vital for
using virtio-scsi reliably (as well as being a one line fix for a
blatant bug).

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora

Paolo Bonzini

unread,
Oct 1, 2012, 9:21:15 AM10/1/12
to Richard W.M. Jones, linux-...@vger.kernel.org, linux...@vger.kernel.org
Il 01/10/2012 15:18, Richard W.M. Jones ha scritto:
> On Mon, Oct 01, 2012 at 03:13:01PM +0200, Paolo Bonzini wrote:
>> Il 20/08/2012 16:05, Paolo Bonzini ha scritto:
>>> Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:
>>>> From: "Richard W.M. Jones" <rjo...@redhat.com>
>>>>
>>>> The sg struct is used without being initialized.
>>>>
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=847548
>>>>
>>>> Signed-off-by: Richard W.M. Jones <rjo...@redhat.com>
>>>> ---
>>>> drivers/scsi/virtio_scsi.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
>>>> index c7030fb..8a66f83 100644
>>>> --- a/drivers/scsi/virtio_scsi.c
>>>> +++ b/drivers/scsi/virtio_scsi.c
>>>> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
>>>> struct scatterlist sg;
>>>> unsigned long flags;
>>>>
>>>> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>>>> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>>>>
>>>> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
>>>>
>>>>
>>>
>>> Acked-by: Paolo Bonzini <pbon...@redhat.com>
>>
>> Ping, is this patch going into 3.7?
>
> I was a bit surprised to see this wasn't upstream since it's vital for
> using virtio-scsi reliably (as well as being a one line fix for a
> blatant bug).

Indeed I enclosed it in a submission named "[PATCH for 3.6] urgent
virtio-scsi fixes"
(http://permalink.gmane.org/gmane.linux.kernel/1350337)...

Paolo
0 new messages