Re: [PATCH] Enable A20 gate

[Ingo Molnar]

* Syed Salman Mansoor <syed.salm...@gmail.com> wrote:

> From a5e4cd6cb1956d288b5a001f60699dc8b5528963 Mon Sep 17 00:00:00 2001
> From: Syed Salman Mansoor <syed.salm...@gmail.com>
> Date: Tue, 7 May 2013 12:49:24 +0500
> Subject: [PATCH] Enable A20 gate
> This is a patch to the a20.c file that fixes following
> warnings/errors found by the checkpatch.pl tool
> i) WARNING: please, no spaces at the start of a line
> ii) WARNING: suspect code indent for conditional statements
> iii) ERROR: trailing whitespace
> Signed-off-by: Syed Salman Mansoor <syed.salm...@gmail.com>
>
> ---
> arch/x86/boot/a20.c | 46 +++++++++++++++++++++++-----------------------
> 1 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/arch/x86/boot/a20.c b/arch/x86/boot/a20.c
> index 64a31a6..911d729 100644
> --- a/arch/x86/boot/a20.c
> +++ b/arch/x86/boot/a20.c
> @@ -129,37 +129,37 @@ static void enable_a20_fast(void)
>
> int enable_a20(void)
> {
> - int loops = A20_ENABLE_LOOPS;
> - int kbc_err;
> + int loops = A20_ENABLE_LOOPS;
> + int kbc_err;
>
> - while (loops--) {
> - /* First, check to see if A20 is already enabled
> + while (loops--) {
> + /* First, check to see if A20 is already enabled
> (legacy free, etc.) */
> - if (a20_test_short())
> - return 0;
> -
> + if (a20_test_short())
> + return 0;
> +
> /* Next, try the BIOS (INT 0x15, AX=0x2401) */
> enable_a20_bios();
> - if (a20_test_short())
> - return 0;
> -
> + if (a20_test_short())
> + return 0;
> +
> /* Try enabling A20 through the keyboard controller */
> kbc_err = empty_8042();
>
> - if (a20_test_short())
> - return 0; /* BIOS worked, but with delayed reaction */
> -
> - if (!kbc_err) {
> - enable_a20_kbc();
> - if (a20_test_long())
> - return 0;
> + if (a20_test_short())
> + return 0; /* BIOS worked, but with delayed reaction */
> +
> + if (!kbc_err) {
> + enable_a20_kbc();
> + if (a20_test_long())
> + return 0;
> }
> -
> +
> /* Finally, try enabling the "fast A20 gate" */
> enable_a20_fast();
> - if (a20_test_long())
> - return 0;
> - }
> -
> - return -1;
> + if (a20_test_long())
> + return 0;
> + }
> +
> + return -1;
> }
> --
> 1.7.2.5

The patch is probably corrupted or not against latest upstream, and the
title of the patch has no relation to what the patch actually does.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

[Syed Salman Mansoor]

Ok thanks fot reply. I will make patch again. Moreover I downloaded
source using git clone
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git so
I assume I had latest code. Also kindly let me know what title means?
The name of patch file?
I am a newbie and trying to learn so that I can contribute whatever I can.

[Jonathan Corbet]

On Tue, 7 May 2013 16:54:23 +0500

Syed Salman Mansoor <syed.salm...@gmail.com> wrote:

> I am a newbie and trying to learn so that I can contribute whatever I can.

If you have not already done so, please have a look at:

Documentation/HOWTO
Documentation/development-process

both of which can be found in your source tree. They will help you to
learn how to work with the kernel development community.

Thanks,

jon