Re: + swap-migration-v5-lru-operations-tweaks.patch added to -mm tree

[Coywolf Qi Hunt]

2005/11/1, ak...@osdl.org <ak...@osdl.org>:
>
> The patch titled
>
> swap-migration-v5-lru-operations-tweaks
>
> has been added to the -mm tree. Its filename is
>
> swap-migration-v5-lru-operations-tweaks.patch
>
>
> From: Andrew Morton <ak...@osdl.org>
>
> Cc: Christoph Lameter <clam...@sgi.com>
> Signed-off-by: Andrew Morton <ak...@osdl.org>
> ---
>
> include/linux/mm_inline.h | 4 +---
> mm/vmscan.c | 6 +++---
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff -puN include/linux/mm_inline.h~swap-migration-v5-lru-operations-tweaks include/linux/mm_inline.h
> --- devel/include/linux/mm_inline.h~swap-migration-v5-lru-operations-tweaks 2005-10-31 21:21:48.000000000 -0800
> +++ devel-akpm/include/linux/mm_inline.h 2005-10-31 21:21:48.000000000 -0800
> @@ -44,8 +44,7 @@ del_page_from_lru(struct zone *zone, str
> *
> * - zone->lru_lock must be held
> */
> -static inline int
> -__isolate_lru_page(struct zone *zone, struct page *page)
> +static inline int __isolate_lru_page(struct zone *zone, struct page *page)
> {
> if (TestClearPageLRU(page)) {
> if (get_page_testone(page)) {

My curiosity, why we do this when the former is friendly to grep? Any
coding style document about this?
--
Coywolf Qi Hunt
http://sosdg.org/~coywolf/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

[Andrew Morton]

It's easier to read.

> Any coding style document about this?

Dunno. I have a rude email from Linus here somewhere from when I used to
do it that way ;)