[PATCH] m68knommu: clean up uClinux boot log output

[Greg Ungerer]

During the arch setup phase of kernel boot we print out in the boot banner
that we are uClinux configured. The printk currently contains a bunch of
useless newlines and carriage returns - producing wastefull empty lines.
Remove these.

Signed-off-by: Greg Ungerer <ge...@linux-m68k.org>
---
arch/m68k/kernel/setup_no.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
index 72d272e..a160695 100644
--- a/arch/m68k/kernel/setup_no.c
+++ b/arch/m68k/kernel/setup_no.c
@@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
process_uboot_commandline(&command_line[0], sizeof(command_line));
#endif /* CONFIG_UBOOT */

- printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
+ printk(KERN_INFO "uClinux with CPU " CPU_NAME "\n");

#ifdef CONFIG_UCDIMM
printk(KERN_INFO "uCdimm by Lineo, Inc. <www.lineo.com>\n");
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Geert Uytterhoeven]

On Fri, Sep 9, 2016 at 3:10 AM, Greg Ungerer <ge...@linux-m68k.org> wrote:
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
> process_uboot_commandline(&command_line[0], sizeof(command_line));
> #endif /* CONFIG_UBOOT */
>
> - printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
> + printk(KERN_INFO "uClinux with CPU " CPU_NAME "\n");

pr_info() while you're at it?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[Greg Ungerer]

Hi Geert,

On 09/09/16 16:21, Geert Uytterhoeven wrote:
> On Fri, Sep 9, 2016 at 3:10 AM, Greg Ungerer <ge...@linux-m68k.org> wrote:
>> --- a/arch/m68k/kernel/setup_no.c
>> +++ b/arch/m68k/kernel/setup_no.c
>> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
>> process_uboot_commandline(&command_line[0], sizeof(command_line));
>> #endif /* CONFIG_UBOOT */
>>
>> - printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
>> + printk(KERN_INFO "uClinux with CPU " CPU_NAME "\n");
>
> pr_info() while you're at it?

If I do that I think I need to do the 12 printk's that follow
that as well :-)

Perhaps I should do that as a separate patch.

Thanks
Greg

[Andreas Schwab]

On Sep 09 2016, Greg Ungerer <ge...@linux-m68k.org> wrote:

> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
> index 72d272e..a160695 100644
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
> process_uboot_commandline(&command_line[0], sizeof(command_line));
> #endif /* CONFIG_UBOOT */
>
> - printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");

Do you have any idea what's the significance of ^O here?

Andreas.

--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."

[Geert Uytterhoeven]

Hi Andreas,

On Fri, Sep 9, 2016 at 4:20 PM, Andreas Schwab <sch...@linux-m68k.org> wrote:
> On Sep 09 2016, Greg Ungerer <ge...@linux-m68k.org> wrote:
>
>> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
>> index 72d272e..a160695 100644
>> --- a/arch/m68k/kernel/setup_no.c
>> +++ b/arch/m68k/kernel/setup_no.c
>> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
>> process_uboot_commandline(&command_line[0], sizeof(command_line));
>> #endif /* CONFIG_UBOOT */
>>
>> - printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
>
> Do you have any idea what's the significance of ^O here?

You raised my interest, too ;-)

http://mailman.uclinux.org/pipermail/uclinux-dev//2003-March/016122.html

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[Greg Ungerer]

Hi Geert, Andreas,

On 10/09/16 00:45, Geert Uytterhoeven wrote:
> Hi Andreas,
>
> On Fri, Sep 9, 2016 at 4:20 PM, Andreas Schwab <sch...@linux-m68k.org> wrote:
>> On Sep 09 2016, Greg Ungerer <ge...@linux-m68k.org> wrote:
>>
>>> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
>>> index 72d272e..a160695 100644
>>> --- a/arch/m68k/kernel/setup_no.c
>>> +++ b/arch/m68k/kernel/setup_no.c
>>> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
>>> process_uboot_commandline(&command_line[0], sizeof(command_line));
>>> #endif /* CONFIG_UBOOT */
>>>
>>> - printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
>>
>> Do you have any idea what's the significance of ^O here?
>
> You raised my interest, too ;-)
>
> http://mailman.uclinux.org/pipermail/uclinux-dev//2003-March/016122.html

The problem with the reasoning there is that this is not the
first string printed. This is what the boot console looks like
now:

Linux version 4.8.0-rc5-00014-g5594b01-dirty (gerg@goober) (gcc
version 5.4.0 (GCC) ) #2 Sat Sep 10 14:44:55 AEST 2016


uClinux/COLDFIRE(m520x)
COLDFIRE port done by Greg Ungerer, ge...@snapgear.com
Flat model support (C) 1998,1999 Kenneth Albanowski, D. Jeff Dionne
Built 1 zonelists in Zone order, mobility grouping off. Total
pages: 4080
Kernel command line: root=/dev/mtdblock0
PID hash table entries: 128 (order: -4, 512 bytes)
Dentry cache hash table entries: 4096 (order: 1, 16384 bytes)
....

So you end up with 2 blank lines for no good reason.

And then there is the question of whether CTRL-O is in any way
useful here. I would argue that it is of pretty much no value
these days - if it ever was:

https://en.wikipedia.org/wiki/Shift_Out_and_Shift_In_characters

Regards
Greg