Minify CSS Cache-Control Headers

[Matt Dean]

So I have minify working as;

 public function minify($f3, $args) {

        $files = preg_replace('/(\.+\/)/', '', $_GET['files']);

        echo \Web::instance()->minify($files, null, true);

    }

and am calling it as;

<link rel="stylesheet" type="text/css" href="/minify?files=/css/reset.css,/css/style.css" />

and my route is;

GET /minify = \controller\Controller->minify, 3600

The minification works and the files are cached in the local file system but the response has a header of Cache-Control:no-store, no-cache, must-revalidate instead of a time

How do I change this?

Thanks

[ikkez]

Your setup looks good to me.

This is handled by the f3->expire method, which should be called automatically when a route caching is active,.. it should happen right here https://github.com/bcosca/fatfree-core/blob/master/base.php#L1587-L1602

I'll test it here

[Matt Dean]

So echoing out the $ttl at 1602 its showing the 3600, also if I add $f3->expire(3600); before the echo in the minify method the cache works as expected.

Looks like something else is unsetting it after the 1602 line.

[ikkez]

do you have some extra rules in your .htaccess or in your nginx config maybe?

[Matt Dean]

Just mod_deflate and the usual rewrites. 

Can't see how they would affect expire in base but not when it is set in the minify method though.

[xfra35]

It could also be caused by:

• the PHP session cache_limiter, if for some reason, you started a session on this route
• a proxy standing in front of Apache (Squid, Varnish, etc.)
  

[Matt Dean]

Turns out one of our other devs had put some extra code in the main controller that was causing this issue. 

I moved this out to its own controller which fixed the issue. Thanks for trying to help :)