Armin Hierstetter
May 9, 2018, 4:35:39 AM5/9/18
to Fat-Free Framework
I recently tried to upgrade from 3.6.0 to 3.6.4.
Armin
But because of changes in the Framework (done in 3.6.1, I believe) regarding the count() method (I guess), nothing works anymore. I am getting errors (unexpected FOREACH), because the results done by COUNT seem to be different than before and there is simply no way I can easily update the two huge projects I developed with F3 because count() is used all over the place. It seems to be a problem when counting a GROUPED select but I am not sure.
I really wonder how you can make those crucial changes without thoroughly testing the effects on existing projects.
Best
Armin
ikkez
May 9, 2018, 5:47:31 AM5/9/18
to Fat-Free Framework
Hi Armin,
I have found this commit being made right after 3.6.0 release, see
https://github.com/bcosca/fatfree-core/commit/68ee97516524fd96663def272f3fc42fff11b0ca#diff-8c8e8a2bd8adc194a9b9f6512f43a772
https://github.com/bcosca/fatfree-core/commit/6b864dc9c329269b5d1bc2427664d3a5e163aec5#diff-8c8e8a2bd8adc194a9b9f6512f43a772
https://github.com/bcosca/fatfree-core/commit/0da17911672db5bbf826472e4f0a82d8c56a1438#diff-8c8e8a2bd8adc194a9b9f6512f43a772
this changes the count method to be able to use an $options array, so you can use count on a query that uses GROUP BY.. that was not possible before, or how did you use it with group before?
I'm sure this behaviour was checked more than twice and I didn't noticed any issues on my projects yet.
Maybe check and compare the generated queries with $db->log() and perhaps we can find the culprit together.
I have found this commit being made right after 3.6.0 release, see
https://github.com/bcosca/fatfree-core/commit/68ee97516524fd96663def272f3fc42fff11b0ca#diff-8c8e8a2bd8adc194a9b9f6512f43a772
https://github.com/bcosca/fatfree-core/commit/6b864dc9c329269b5d1bc2427664d3a5e163aec5#diff-8c8e8a2bd8adc194a9b9f6512f43a772
https://github.com/bcosca/fatfree-core/commit/0da17911672db5bbf826472e4f0a82d8c56a1438#diff-8c8e8a2bd8adc194a9b9f6512f43a772
this changes the count method to be able to use an $options array, so you can use count on a query that uses GROUP BY.. that was not possible before, or how did you use it with group before?
I'm sure this behaviour was checked more than twice and I didn't noticed any issues on my projects yet.
Maybe check and compare the generated queries with $db->log() and perhaps we can find the culprit together.
Reply all
Reply to author
Forward
0 new messages