adding SLES support to puppet-puppet

[Sean Alderman]

Hi,

  I'm working on adding SLES support into the puppet-puppet module.  SLES uses an /etc/sysconfig/puppet file like debian, not a big deal really, but what I've run into is that it seems like somewhere along the line the module code has had the service_autorestart parameter default changed from true (how it's documented in init.pp) to false.

  Is that how you want it?  It seems like all/most modules have this autorestart set default to true so that when configs are modified the service gets a bounce.  I'll patch that, but I can't seem to formulate a proper search in github to figure when that changed or what PR its related to.

Thanks.

[Alessandro Franceschi]

Yes, the service_autorestart is disabled by default to avoid that during a puppet run the service is restarted with unpredictable consequences.

So it's a wanted behaviour for this case which eventually should be better documented

al

[Sean Alderman]

Ok that makes sense, though I've never seen bad things happen to date. 

I guess I must have been using a way out of date params.pp or something.  I've been able to modify the node environment from Foreman and watch it apply and the service restart on the nodes w/o issue up until I pulled the latest and strarted working on getting SLES going.