Indentation fixes for go.

4 views
Skip to first unread message

Phil Norman

unread,
Sep 25, 2018, 12:53:28 PM9/25/18
to evergre...@googlegroups.com
In case anyone else uses Evergreen for Go, I've just submitted a couple of fixes:
1: Evergreen won't change indentation within a multi-line string any more.
2: Unmatched brackets inside strings no longer have an effect on indentation level further down the file.

If there are unforeseen side-effects (aka bugs), please let me know.

Thanks,
Phil

Martin Dorey

unread,
Sep 26, 2018, 4:23:44 PM9/26/18
to Evergreen Users
What is git(hub) on about with claiming that Phil did anything in https://github.com/software-jessies-org/jessies/commit/1b6e5af204db9556fc56a353ee7dba7b2ab49988?

martind@swiftboat:~/jessies/work/salma-hayek/lib/data$ git blame spelling-exceptions-C++ | grep -v Elliott | grep -v Martin | grep -v enh
martind@swiftboat:~/jessies/work/salma-hayek/lib/data$ 

That's the kind of nonsense I've come to expect from Mercurial.  I naively expected git(hub) to be better.  Wouldn't happen with BitKeeper, mutter mutter.

--
You received this message because you are subscribed to the Google Groups "evergreen-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to evergreen-use...@googlegroups.com.
To post to this group, send email to evergre...@googlegroups.com.
Visit this group at https://groups.google.com/group/evergreen-users.
For more options, visit https://groups.google.com/d/optout.

Phil Norman

unread,
Sep 26, 2018, 5:18:44 PM9/26/18
to evergre...@googlegroups.com
Woah, turns out I'm magic. Who'd have thought?

Elliott Hughes

unread,
Oct 6, 2018, 10:14:38 PM10/6/18
to evergre...@googlegroups.com

seems like github isn't very smart when someone else has made changes before you push. even if they don't conflict, you get this. (it's quite possible this is happening in AOSP too, but there there's so much noise from all the automergers that you have to ignore all the synthetic commits [i forget what the actual git word is] anyway.)

Martin Dorey

unread,
Oct 6, 2018, 10:55:59 PM10/6/18
to evergre...@googlegroups.com
That's maddening.  I can't understand that without the original check-in comment, 
Reply all
Reply to author
Forward
0 new messages