Error links from ctrl-B build.

[Phil Norman]

Hi.

Doing some recent hacking on Jessies, I tried using the ctrl-B build-in-a-window feature (which I never use normally). I found two annoyances, both of which I remember being covered a while back. Quite a long while back.

1: Clicking on error links yields a "can't find the file" error from Evergreen.

2: Every build opens a new window.

Now for [1], I seem to remember it being because a build from jessies enters subdirectories to call make from them, and the errors are then relative to those paths. It should be possible to figure out directory changes because make prints out "entering directory $foo", but I think it was considered too annoying to do. Is that right? Any reason why I shouldn't change Evergreen to watch out for such messages and interpret them?

For [2], there was some discussion that it could be useful to keep the old output. Would anyone be against adding an option so the user could choose to either clear-and-reuse the same errors window, or open a new one each time? Shouldn't be too hard.

Cheers,

Phil

[Martin Dorey]

> 1: Clicking on error links yields a "can't find the file" error from Evergreen.

So it does.  Hmm, I bet I can guess why that is.

...

Yes.  I applied the necessary one character fix with:

https://github.com/software-jessies-org/jessies/commit/a933ace017664f421fc562dbcbf9dd7d3b86303d

> 2: Every build opens a new window.

> there was some discussion that it could be useful to keep the old output.

Was there?

> Would anyone be against adding an option so the user could choose to either clear-and-reuse the same errors window, or open a new one each time?

I doubt I'm fussed either way.  github, unhelpfully, won't go back far enough, perhaps because of a rename, but revisiontool's git support is better than that (ha!) and says that current behavior dates from [

2009-01-03 00:55:52 +0000 enh@0f49fcda-c99d-ebdb-567f-4e9c527d7ea3 (7a7e7669a28092c008a5027fd65b52486d2be0fb)

src/e/edit/BuildAction.java: src/e/edit/CheckForLintAction.java: src/e/edit/EErrorsWindow.java: src/e/edit/Evergreen.java: src/e/edit/ExternalToolAction.java: src/e/edit/KillErrorsAction.java: src/e/edit/ShellCommand.java: src/e/edit/StreamMonitor.java: src/e/edit/Workspace.java: move to having more than one EErrorsWindow per Workspace, so you can do multiple things at once and keep the output separate.

].

--
You received this message because you are subscribed to the Google Groups "evergreen-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to evergreen-users+unsubscribe@googlegroups.com.
To post to this group, send email to evergreen-users@googlegroups.com.
Visit this group at https://groups.google.com/group/evergreen-users.
For more options, visit https://groups.google.com/d/optout.

[Phil Norman]

On 13 February 2018 at 03:48, Martin Dorey <marti...@gmail.com> wrote:

> 1: Clicking on error links yields a "can't find the file" error from Evergreen.

So it does.  Hmm, I bet I can guess why that is.

...

Yes.  I applied the necessary one character fix with:

Yep, saw that. Thanks a lot :-)

 

> 2: Every build opens a new window.

> there was some discussion that it could be useful to keep the old output.

Was there?

> Would anyone be against adding an option so the user could choose to either clear-and-reuse the same errors window, or open a new one each time?

I doubt I'm fussed either way.  github, unhelpfully, won't go back far enough, perhaps because of a rename, but revisiontool's git support is better than that (ha!) and says that current behavior dates from [

2009-01-03 00:55:52 +0000 enh@0f49fcda-c99d-ebdb-567f-4e9c527d7ea3 (7a7e7669a28092c008a5027fd65b52486d2be0fb)

src/e/edit/BuildAction.java: src/e/edit/CheckForLintAction.java: src/e/edit/EErrorsWindow.java: src/e/edit/Evergreen.java: src/e/edit/ExternalToolAction.java: src/e/edit/KillErrorsAction.java: src/e/edit/ShellCommand.java: src/e/edit/StreamMonitor.java: src/e/edit/Workspace.java: move to having more than one EErrorsWindow per Workspace, so you can do multiple things at once and keep the output separate.

Hmm, maybe Elliott can chime in with what behaviour he intended. I doubt the intention was quite this spammy :-)