Am 25.03.13 05:39, schrieb ddevore:
Awesome, looking forward to see it.
The asynchronicity (sound's like a police song ;-)) was a
little more challenging than I thought.
Yes, I tried to cover the most tricky things in
AWRS
but I'm sure that life can be further simplified for
implementors in the future.
I also have lots of good tests to add to both journals.
Tests rock :)
In rethinking the layout I'm wondering if Casbah and
ReactiveMongo should be different journal's all together. For
example:
- es-journal-casbah-mongodb
- es-journal-reactive-mongodb
Currently the both would be under es-journal-mongodb
WDYT?
If you want to avoid that casbah/reactive deps are always pulled
together then separate subprojects make sense. Otherwise they should
go into the same subproject and, depending on the
available/necessary configuration options once could either use the
same MongoJournalProps class object with a sync/async config option
for both journals or different JournalProps classes if the config
options strongly differ between these two journals.
Should you want to go for two different subprojects, I propose using
the names
- es-journal-mongodb-casbah
- es-journal-mongodb-reactive
My personal preference is using different subprojects.
The
preceding email message may contain confidential information of
Viridity Energy, Inc. It is not intended for transmission to, or
receipt by, any unauthorized persons. If you have received this
message in error, please (i) do not read it, (ii) reply to the
sender that you received the message in error, and (iii) erase
or destroy the message.