Suggestion

1 view
Skip to first unread message

johnvh

unread,
Mar 16, 2010, 3:18:46 PM3/16/10
to EventController
Good job, but I noticed a glaring issue:

You're coding against the concrete implementation of EventDispatcher.
This means that everything MUST extend EventDispatcher to work with
EventController. Fortunately, nearly everything (especially the native
flash lib) does. It is possible thought to not extend EventDispatcher
and instead implement the IEventDispatcher interface. Coding against
the interface will allow you to work with both cases, and should not
introduce any regressions (EventDispatcher just implements the
interface).

Thanks

corbanb

unread,
Mar 17, 2010, 9:09:30 AM3/17/10
to EventController
Man that's a GREAT idea! I think that should be a very easy change to
make. Let me take a quick look at it and I will see what we can do.
It's the early stages of the code so any and all great recommendations
like this are perfect! Thanks as always John!

Ben Fhala

unread,
Mar 17, 2010, 11:24:19 AM3/17/10
to eventco...@googlegroups.com
love that, thanks :)
updated the svn to use the IEventDispatcher instead of the EventDispatcher.

Thanks great feedback will update the zip later but its up on the svn for now. anything that opens the door to more developers without drastic changes is sweet , thanks for looking so deeply into it and so quickly.

https://code.google.com/p/eventcontroller/source/checkout


--
Best regards,

Ben Fhala
http://fla.as/ec






Reply all
Reply to author
Forward
0 new messages