Issue 46 in es-operating-system: Code review request

0 views
Skip to first unread message

codesite...@google.com

unread,
Oct 8, 2009, 12:40:45 AM10/8/09
to es-operatin...@googlegroups.com
Status: New
Owner: Shiki.Okasaka
CC: es-opera...@googlegroups.com
Labels: Type-Review Priority-Medium Initialpatch

New issue 46 by 17.neeraj.s: Code review request
http://code.google.com/p/es-operating-system/issues/detail?id=46

Purpose of code changes on this branch:
enhances the setup script to handle error conditions more gracefully

File to be reviewed:
/trunk/setup

After the review, I'll merge this branch into:/trunk

Textual Description:
1. added function for manual input of archives in case wget fails.
2. add the export statement for es-tools in users .bashrc
3. exit with appropriate exit status in case a command fails

Note: Please ignore the /trunk/my_setup file in this revision. It was a
temporary file.Have Deleted it in next revision.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

codesite...@google.com

unread,
Oct 8, 2009, 12:57:08 AM10/8/09
to es-operatin...@googlegroups.com

Comment #1 on issue 46 by Shiki.Okasaka: Code review request
http://code.google.com/p/es-operating-system/issues/detail?id=46

When requesting a code review, please include the minimum set of files that
need to
be reviewed in your trunk copy. In other words, you'll need to keep
multiple trunk
copies under your branch. Please take a look into branches/gsoc2009/kala as
an example.

codesite...@google.com

unread,
Oct 8, 2009, 4:18:35 AM10/8/09
to es-operatin...@googlegroups.com
Updates:
Status: WontFix

Comment #2 on issue 46 by Shiki.Okasaka: Code review request
http://code.google.com/p/es-operating-system/issues/detail?id=46

(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages