Issue 31 in es-operating-system: Code review request

[codesite...@google.com]

Status: New
Owner: Ishibashi.Kenichi
CC: Shiki.Okasaka, joao.taveira, es-opera...@googlegroups.com
Labels: Type-Review Priority-Medium

New issue 31 by ailvpeng25: Code review request
http://code.google.com/p/es-operating-system/issues/detail?id=31

Purpose of code changes on this branch:
limited listen queue length support.

When reviewing my code changes, please focus on:
1183

After the review, I'll merge this branch into:
/trunk

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

[codesite...@google.com]

Comment #1 on issue 31 by Ishibashi.Kenichi: Code review request
http://code.google.com/p/es-operating-system/issues/detail?id=31

Most of your code looks good to me, but I have a comment on
StreamReceiver::StateListen::input(). When the listen queue length exceed
the limit,
we should call accepted->abort() before return with false.

Please commit this change to the trunk after dealing with avobe comment.

[codesite...@google.com]

Comment #2 on issue 31 by ailvpeng25: Code review request
http://code.google.com/p/es-operating-system/issues/detail?id=31

Thank you Kenichi,
I have fixed StreamReceiver::StateListen::input() in r1187, and commit to
the trunk
in r1189

[codesite...@google.com]

Comment #3 on issue 31 by ailvpeng25: Code review request
http://code.google.com/p/es-operating-system/issues/detail?id=31

Thank you Shiki,

Sorry, I see your comment after I commit to the trunk.
Please revert this commit to the trunk,that is r1189

[codesite...@google.com]

Updates:
Status: Invalid

Comment #4 on issue 31 by Ishibashi.Kenichi: Code review request
http://code.google.com/p/es-operating-system/issues/detail?id=31

(No comment was entered for this change.)