How do you build error-prone-javac

[John Edmonds]

I was trying to make some changes to https://github.com/google/error-prone-javac but it doesn't look like there are any instructions to compile the jar file used by error-prone. Does anyone know how to do it?

[Eddie Aftandilian]

I believe following the directions for upstream langtools will work:

http://openjdk.java.net/projects/compiler-grammar/build.html

Can you give that a try and and let us know?

On Fri, Jan 19, 2018 at 1:49 PM, John Edmonds <john.a....@gmail.com> wrote:

I was trying to make some changes to https://github.com/google/error-prone-javac but it doesn't look like there are any instructions to compile the jar file used by error-prone. Does anyone know how to do it?

--
Googlers: This an external list. Please be careful when posting.
---
You received this message because you are subscribed to the Google Groups "error-prone-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to error-prone-discuss+unsub...@googlegroups.com.
Visit this group at https://groups.google.com/group/error-prone-discuss.
To view this discussion on the web visit https://groups.google.com/d/msgid/error-prone-discuss/f67752dc-548e-4612-9e92-43ee56a1a603%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[John Edmonds]

Thanks for the reply!

I tried that and got
Target "build-javac" does not exist in the project "langtools".

So what I've found so far:

• It is possible to run ant -f make/build.xml -Dlangtools.jdk.home=$JAVA_HOME but it uses the new Java 9 module system. So it doesn't produce a jar like the one currently in use. Instead it just produces folders with classes
  
• I know it is possible to produce a jar since there's one at http://www.mvnrepository.com/artifact/com.google.errorprone/javac/9-dev-r4023-1
• Moreover I know that somehow the jar is able to target java 8 since if you extract any of the classfiles, they all have major version 52 (AKA java 8). I'd like it to target java 8 since I don't think Bazel supports java 9 yet.
  
• It looks like the rules used to be there (https://github.com/google/error-prone-javac/blob/jdk9-dev/make/build.xml#L197) but they've since been removed.

I guess the more specific question is how was the jar for http://www.mvnrepository.com/artifact/com.google.errorprone/javac/9-dev-r4023-1 produced?

[Eddie Aftandilian]

OK, I looked into this and found the commands we use to build.  The exact commands change from version to version, but I can confirm that these commands successfully build a jar from the "9+181-r4173-1" branch on our Github repo.  This will leave a JAR in the current directory that should match what you see on Maven Central.  Note that you will need both a JDK8 and JDK9 to successfully build.  

VERSION=9+181-r4173-1

JDK8=<path_to_jdk_8>

JDK9=<path_to_jdk_9>

(

set -eux

ant -buildfile make/build.xml -Dboot.java.home=${JDK8} -Dlangtools.jdk.home=${JDK9} clean build

mkdir out

${JDK8}/bin/javac $(find build/gensrc/jdk.compiler/ -name '*.java') $(find src/java.compiler/share/classes/ -name '*.java' | grep -v module-info.java) $(find src/jdk.compiler/share/classes/ -name '*.java' | grep -v module-info.java | grep -v JavacToolProvider.java) -d out

cp -R ./src/jdk.compiler/share/classes/META-INF out/

(cd out && jar cvf0 ../javac-${VERSION}.jar .)

)

On Mon, Jan 22, 2018 at 1:58 PM, John Edmonds <john.a....@gmail.com> wrote:

Thanks for the reply!

I tried that and got
Target "build-javac" does not exist in the project "langtools".

So what I've found so far:

• It is possible to run ant -f make/build.xml -Dlangtools.jdk.home=$JAVA_HOME but it uses the new Java 9 module system. So it doesn't produce a jar like the one currently in use. Instead it just produces folders with classes
  
• I know it is possible to produce a jar since there's one at http://www.mvnrepository.com/artifact/com.google.errorprone/javac/9-dev-r4023-1
• Moreover I know that somehow the jar is able to target java 8 since if you extract any of the classfiles, they all have major version 52 (AKA java 8). I'd like it to target java 8 since I don't think Bazel supports java 9 yet.
  
• It looks like the rules used to be there (https://github.com/google/error-prone-javac/blob/jdk9-dev/make/build.xml#L197) but they've since been removed.

I guess the more specific question is how was the jar for http://www.mvnrepository.com/artifact/com.google.errorprone/javac/9-dev-r4023-1 produced?

On Monday, January 22, 2018 at 3:00:51 PM UTC-5, Eddie Aftandilian wrote:

I believe following the directions for upstream langtools will work:

http://openjdk.java.net/projects/compiler-grammar/build.html

Can you give that a try and and let us know?

On Fri, Jan 19, 2018 at 1:49 PM, John Edmonds <john.a....@gmail.com> wrote:

I was trying to make some changes to https://github.com/google/error-prone-javac but it doesn't look like there are any instructions to compile the jar file used by error-prone. Does anyone know how to do it?

--
Googlers: This an external list. Please be careful when posting.
---
You received this message because you are subscribed to the Google Groups "error-prone-discuss" group.

To unsubscribe from this group and stop receiving emails from it, send an email to error-prone-discuss+unsubscribe...@googlegroups.com.

Visit this group at https://groups.google.com/group/error-prone-discuss.
To view this discussion on the web visit https://groups.google.com/d/msgid/error-prone-discuss/f67752dc-548e-4612-9e92-43ee56a1a603%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
Googlers: This an external list. Please be careful when posting.
---
You received this message because you are subscribed to the Google Groups "error-prone-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to error-prone-discuss+unsub...@googlegroups.com.
Visit this group at https://groups.google.com/group/error-prone-discuss.

To view this discussion on the web visit https://groups.google.com/d/msgid/error-prone-discuss/fab19610-1e16-47e6-a15f-f98111fd714c%40googlegroups.com.

[John Edmonds]

Thank you so much this is exactly what I wanted. I can confirm it generates the jar.

To unsubscribe from this group and stop receiving emails from it, send an email to error-prone-discuss+unsub...@googlegroups.com.
Visit this group at https://groups.google.com/group/error-prone-discuss.
To view this discussion on the web visit https://groups.google.com/d/msgid/error-prone-discuss/f67752dc-548e-4612-9e92-43ee56a1a603%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.