Suppress existing errors

14 views
Skip to first unread message

Nakul Joshi

unread,
May 9, 2024, 12:50:31 PMMay 9
to error-prone-discuss
Adding ErrorProne to an existing codebase can be a lot of work. A lot of teams are not receptive to adding a new tool AND reviewing multiple changes to fix the existing codebase. Adding suppressions manually is also time consuming.

It would be nice if errorprone either-
  1. Provided a patcher that added the appropriate suppression warnings with some configurable explanation comment (eg. "grandfathered existing error")
  2. Could dump existing warnings into a suppressions.xml, which would then be ignored for future runs.

Liam Miller-Cushon

unread,
May 13, 2024, 9:13:56 AMMay 13
to error-prone-discuss
Hello,

I agree it would be nice to have a documented workflow for this. There's a related FR in https://github.com/google/error-prone/issues/3163, I left a note there.

Nakul Joshi

unread,
May 13, 2024, 10:41:51 AMMay 13
to error-pro...@googlegroups.com
Oops, that was from me 😅 I forgot I posted that sorry!

--
Googlers: This an external list. Please be careful when posting.
---
You received this message because you are subscribed to a topic in the Google Groups "error-prone-discuss" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/error-prone-discuss/cw0UWFGCfKc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to error-prone-dis...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/error-prone-discuss/f51aac13-cc9c-48ec-8d93-26a629a8a35an%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages