Contributing to ERPNext

99 views
Skip to first unread message

Rushabh Mehta

unread,
Jul 15, 2013, 2:57:35 AM7/15/13
to erpnext-dev...@googlegroups.com
Dear all,

Since we have started getting some contributions from the community we will need to address the issue of copyrights. There is an interesting discussion on this in the partner forum (https://groups.google.com/forum/#!topic/erpnext-partners-forum/JTil8rMAfdA) and I think it is important to clarify some issues around GPL.

Please read this file and give your comments. It has general guidelines and a section relating to copyrights.


best,
Rushabh



T: @rushabh_mehta

Bradley M. Kuhn

unread,
Nov 19, 2013, 3:33:42 PM11/19/13
to erpnext-par...@googlegroups.com, erpnext-dev...@googlegroups.com, Rushabh Mehta, Dale Scott
My employer recently started a project to build non-profit accounting
software for non-profit organizations (see
https://sfconservancy.org/campaign/ for details). As a first phase of
this project, we're evaluating every Open Source and Free Software
accounting package we can find (see
http://npoacct.sfconservancy.org/ExistingProjects/ ).

Thus, while I note that this thread about ERPNext's copyright policy
ended back on July 17th, and my comments are coming very late, I only
looked in detail at this issue on last Friday, so I'm commenting on this
thread now.

My colleague and I were evaluating ERPNext, and we encountered this
policy found at:
https://github.com/webnotes/erpnext#copyright-for-contributors
which reads:
>> Unless otherwise asserted in the code files, Web Notes will own the
>> copyright of all contributions too. That means Web Notes holds the
>> rights to change the license in the future or offer Commercial
>> Licenses.

This seems to me as if it's some sort of implicit CLA and/or ©AA, but a
unilateral statement of like this -- particularly one that doesn't
define what it means for something to be a "contribution" -- seems
unlikely to automatically "cause" someone to *assign* their copyrights
merely by failing to put a copyright notice on a file. I'd suspect this
doesn't hold up under legal analysis.

I'd like to point out that this policy is problematic not only because
it may not be valid under copyright rules in most countries, but also
because the policy that it seeks to implement is IMO problematic for
various reasons.

The key issue is that it treats the community as unequal under the GPL.
The GPL is valuable because it creates equal rights for all in the
codebase. However, if Web Notes reserves the rights to have more power
over the codebase than everyone else by reserving the right to
proprietary relicense, that policy creates community inequity.

Moreover, if Web Notes does fix the policy such that copyright
assignment for most contributions does become mandatory, any USA
501(c)(3) on-profit organization (like the one I work for) probably has
to avoid contributing upstream to the ERPNext codebase entirely, at
least for contributions where Web Notes makes copyright assignment
mandatory.

That's because a 501(c)(3) non-profit charity can't simply "give away"
assets like copyrights to a for-profit company, due to various rules by
the IRS in the USA. Thus, it wouldn't be possible for potential
non-profit contributors like myself to contribute to the main codebase,
*even if* we wanted to give up our rights under GPL entirely (which we
don't want to do, in any event).

The options that leaves us is to fork ERPNext under GPL (which of course
we don't have the resources to do), or to look at other codebases that
we can participate in without copyright assignment. We're likely to do
the latter at this point, but I wanted to raise this issue to (a)
possibly help clarify and correct this policy, and/or (b) to register
for the record that this policy was the reason we had to give up on
considering adoption of the ERPNext codebase.


Meanwhile, I noticed a few things in that thread back in July that I
thought it might be useful to comment on, also for the record.

Dale Scott said in July:
>>> 2. License. The key here is that the license is granted by the
>>> copyright owners. If the copyright owners are ambiguous, the license
>>> is ambiguous.

While the first sentence is correct, I don't see how it leads to the
conclusion in the second sentence. I think the point Dale was perhaps
trying to make (which I *would* agree with) is that projects need to be
sure that all copyright holders have agreed to submit their changes
under the license of the project (in ERPNext's case, the GPL).
Ironically, the existing policy in README.md makes the situation *worse*
on this point (IMO), because that policy is tries to create a copyright
assignment agreement implicitly, based on ambiguous conditions.

Did you perhaps consider using something like Linux's DCO, wherein
developers add Signed-Off-By to their commits to indicate they have
permission to contribute the change under the license of the project?
That is a good way to deal with that ambiguity.

Meanwhile, on a semi-related issue, Rushabh wrote on July 13th:
> I personally like GPL, but in practice unless you are a big foundation
> there is nothing you can really do if someone violates the GPL and
> does not maintain the same license in the derivatives

I truly don't understand what Rushabh's point here. Consistently, for a
decade and a half, I've been involved with and/or in charge of more GPL
enforcement than any other person on the planet in history. I've never
worked anywhere "big" -- indeed, I've worked only for tiny non-profit
organizations for most of my career. Thus, Rushabh's point is
completely incongruent with my direct, practical (, and quite
substantial) experience with GPL enforcement. It's true that GPL
enforcement requires work, and it's often quite boring and tedious work,
but it's also not very difficult, either.

I wonder, given Rushabh's comment: did ERPNext have a GPL violation that
was unresolved? Is there anything I can do to help on that?
--
-- bkuhn

Dale Scott

unread,
Nov 19, 2013, 9:46:41 PM11/19/13
to Bradley M. Kuhn, erpnext-par...@googlegroups.com, erpnext-dev...@googlegroups.com, Rushabh Mehta
> -----Original Message-----
> From: Bradley M. Kuhn [mailto:bk...@ebb.org]
> Sent: Tuesday, November 19, 2013 1:34 PM
...
> Dale Scott said in July:
> >>> 2. License. The key here is that the license is granted by the
> >>> copyright owners. If the copyright owners are ambiguous, the license
> >>> is ambiguous.
>
> While the first sentence is correct, I don't see how it leads to the conclusion in
> the second sentence.

The point I was trying to make was simpler than that. My thought was that, if it's not clear who the copyright holder is, then it's not clear who has authority to grant a license, and if that's not clear, then I can't see how a license can be understood to be valid (i.e. as if there was no license).

The overall point of my postings were to recommend "make the legal stuff simple and consistent and more *big business* will be able to participate". I'm generalizing about large organizations who care about rules, but more from a perspective of avoiding corporate liability than an understanding of FOSS and participating in the community.

However, this may not be a legally valid argument (I'm not a lawyer, and don't even play one on TV), so I'll bow to your experience Bradley.

Dale


Rushabh Mehta

unread,
Nov 20, 2013, 12:10:11 AM11/20/13
to Bradley M. Kuhn, erpnext-par...@googlegroups.com, erpnext-dev...@googlegroups.com, Dale Scott
Bradley,

Thanks for taking the time for looking into this project and your educative mail. Your campaign is very interesting and we would be very happy if you want to consider ERPNext.

Regarding the copyright issues - We are happy to change the problematic line (removed: https://github.com/webnotes/erpnext/commit/b340d06fe6b3cbc51e5f8cc6e06f73a1605d5765). The thought was that, incase we want to change the license in the future (to a more permissible one) or issue a commercial license for closed sourced development, it could be a useful. But as things stand we are not going in that direction and are happy with the GPL License. Our reference is again Wordpress which is licensed as GPL.

I have also changed the copyright as "Web Notes Technologies Pvt Ltd (Web Notes) and Contributors".

Also very happy to know that organizations like yours are there for protecting GPL violations. So far I don't think there has been a violation that warrants an escalation. Its just that most developers don't want to maintain public forks (just my understanding from the forum, where there are many questions asked, but no public fork shared). Either ways, we think its too early to even evaluate any action. As a first step, maybe we could make it a habit only to offer help on the forum if a public fork is shared.

Would also like to express our interest in participating in your project, if you find this codebase useful. If there is any other problem we will be happy to fix it. 

best,
Rushabh







W: https://erpnext.com
T: @rushabh_mehta

Bradley M. Kuhn

unread,
Nov 20, 2013, 12:14:46 PM11/20/13
to erpnext-dev...@googlegroups.com, erpnext-par...@googlegroups.com, Rushabh Mehta
Dale Scott wrote at 21:46 (EST) on Tuesday:
> The point I was trying to make was simpler than that. My thought was
> that, if it's not clear who the copyright holder is, then it's not
> clear who has authority to grant a license, and if that's not clear,
> then I can't see how a license can be understood to be valid (i.e. as
> if there was no license).

Ah, yes, I definitely agree with that as well.

--
-- bkuhn
Reply all
Reply to author
Forward
0 new messages