gradle build (http://code.orbitz.net/browse/ERMA-27)

3 views
Skip to first unread message

Greg Opaczewski

unread,
Mar 7, 2010, 1:42:29 PM3/7/10
to erma...@googlegroups.com
Here is the link to the branch :

http://github.com/erma/erma/tree/gradlebuild

It took a bit of hackery to produce the same artifacts (jars) without
refactoring the project structure, so if someone would like to take a
stab at splitting api,lib,test into separate modules that would be a
good way to learn Gradle. Feedback/improvements to the build are of
course welcome.

Any objections to merging this into next as the foundation for 4.0?

Greg

Stephen Mullins

unread,
Mar 7, 2010, 8:36:26 PM3/7/10
to erma...@googlegroups.com
I'll take a look at this branch this week. No objections from me for merging this into next. What are we using the master branch for with the erma account, the latest released version?

Stephen


--
You received this message because you are subscribed to the Google Groups "erma-core" group.
To post to this group, send email to erma...@googlegroups.com.
To unsubscribe from this group, send email to erma-core+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/erma-core?hl=en.


Matthew Kemp

unread,
Mar 11, 2010, 11:10:38 AM3/11/10
to erma...@googlegroups.com
I looked through this and it looks fine for an initial gradle build. I think that changing the project structure would be a nice improvement. As well as converting the codebase to Java 1.5+ style code (generics, foreach, etc).

Stephen Mullins

unread,
Mar 14, 2010, 2:41:55 PM3/14/10
to erma...@googlegroups.com
This code looks great now Greg. No more checked in dependencies! Gradle is pretty slick as well. I really like how running the test target generates a pretty html report for the test suite, latency for each test, highlighted failures, etc.

I followed your readme instructions (like all two of them) and they worked fine so you've definitely made it easier for new developers to get started with erma.

The only tiny thing I changed was gitignore in my fork (obviously not needed for release):
http://github.com/smullins7/erma/commit/de705c32f202e0f7ba2576777d2b4ddf71e617be

I'd like to take a stab at breaking the project into modules this week. I'll be out of town for a week starting Friday so if I can't get to it by then it will be a little while before I'll look at it again.

All in all good job on this work.

Stephen
Reply all
Reply to author
Forward
0 new messages