erlydb_mnesia patch for get_metadata

2 views
Skip to first unread message

Michael Mullis

unread,
Dec 3, 2008, 12:29:59 PM12/3/08
to erlyweb
Hi.
erlydb_mnesia:get_metadata current code throws an error.
Please review and apply the following patch.
thanks, michael.
======

diff --git a/src/erlydb/erlydb_mnesia.erl b/src/erlydb/
erlydb_mnesia.erl
index bd7a136..54a66bb 100644
--- a/src/erlydb/erlydb_mnesia.erl
+++ b/src/erlydb/erlydb_mnesia.erl
@@ -184,11 +184,10 @@ start(_Options) ->
get_metadata(_Options) ->
% NOTE Integration with mnesia_rdbms would be interesting...
Tables = mnesia:system_info(tables) -- [schema],
- Tree = lists:foldl(
- fun(Table, TablesTree) ->
- gb_trees:enter(Table, get_metadata(Table, table_fields
(Table)), TablesTree)
- end, gb_trees:empty(), Tables),
- {ok, Tree}.
+ lists:foldl(
+ fun(Table, TablesTree) ->
+ gb_trees:enter(Table, get_metadata(Table, table_fields
(Table)), TablesTree)
+ end, gb_trees:empty(), Tables).

get_metadata(Table, Fields) when is_list(Fields) ->
[get_metadata(Table, Field) || Field <- Fields];
@@ -356,6 +355,7 @@ select(Modifier, Fields, Tables, WhereExpr,
Extras, Options, QHDesc) ->
end,
QLC1 = QLC ++ " || " ++ comma(Desc#qhdesc.generators ++ lists:reverse
(Desc#qhdesc.filters)) ++ "].",
?L(["About to execute QLC: ", QLC1]),
+ ?L(["With bindings : ", Desc#qhdesc.bindings]),
{atomic, Results} = transaction(
fun() ->
QHOptions = Desc#qhdesc.options,

John Webb

unread,
Dec 4, 2008, 5:55:41 PM12/4/08
to erl...@googlegroups.com
+1.

I'd like to see this fix included, please.

-jw

Yariv Sadan

unread,
Dec 8, 2008, 10:49:27 PM12/8/08
to erl...@googlegroups.com
will do
Reply all
Reply to author
Forward
0 new messages