Code merges, $OTPROOT and version discovery

17 views
Skip to first unread message

Wolfgang Schell

unread,
Sep 22, 2011, 4:55:51 PM9/22/11
to erj...@googlegroups.com
Hi Kresten,

I just saw, that you merged some of my changes from the miscchanges
branch of jetztgradnet/erjang. Did you look over all changes? Some of
them (especially the ones regarding $OTPROOT and version discovery as
well as the stdio changes) I wanted to test some more before creating a
pull request. One case that was missing is $OTPROOT and version
discovery with Erlang from the classpath. Did you try this before
pushing to trifork/erjang? I think it might need some more work for this
case. But I plan to dig into that this weekend.

Regards,

Wolfgang

Kresten Krab Thorup

unread,
Sep 22, 2011, 5:19:13 PM9/22/11
to Wolfgang Schell, erj...@googlegroups.com
Hi Wolfgang,

Right; as it is right now it still only works if the correct path is configured in erjang_cfg.properties; so my commit did not include removing (or rather commenting out) those lines.

I just got dragged into it because I was fixing erlang:halt. Sorry if I was too quick there :-)

Kresten

Mobile: + 45 2343 4626 | Skype: krestenkrabthorup | Twitter: @drkrab
Trifork A/S | Margrethepladsen 4 | DK- 8000 Aarhus C | Phone : +45 8732 8787 | www.trifork.com<http://www.trifork.com/>

Reply all
Reply to author
Forward
0 new messages