Re: [EPx Developers] Contribute to code EPx?

[Jeremiah Crossett]

Neal, 

I did not hear back from you-- is it possible to contribute to the project? 

  Not sure-- has there been any changes from standard E+ by EPx yet? 

Jeremiah D. Crossett  | Senior Analyst  |  Phase Change Energy Solutions

120 E. Pritchard St.  | Asheboro, NC 27203 

 | Mobile 503-688-8951

www.phasechange.com 

  

On Thu, Jan 30, 2014 at 1:27 PM, Jeremiah Crossett <jcro...@phasechange.com> wrote:

Neal, 

I have attached my code in a zip file.  Most of the changes are to HeatBalFiniteDifferenceManager.f90, with small additions to DataHeatBalancef90 and SurfaceGeometry.f90. 

Also included is documentation in word doc format. 

Please let me know if this work can be contributed to EPx? 

Jeremiah D. Crossett  | Senior Analyst  |  Phase Change Energy Solutions

120 E. Pritchard St.  | Asheboro, NC 27203 

 | Mobile 503-688-8951

www.phasechange.com 

  

On Wed, Oct 30, 2013 at 8:27 AM, Neal Kruis <neal....@bigladdersoftware.com> wrote:

Jeremiah,

We welcome anyone interested in contributing to EPx. Currently there are a few people with read/write access to the SVN repository. For those without read/write access you can send us files you have changed and we will review them before committing them to the repository. After a few submittals we can look into getting you read/write access as well. 

We are still establishing a vetting process for adding new committers to the repository, but for now feel free to post any changes you make to the code and we will look into merging them into the development branch.

Thanks for your interest!

Neal

On Tuesday, October 29, 2013 3:42:44 PM UTC-6, NRGSIM wrote:

Mengsong, I'm not sure about the tutorial, but I am compiling just fine with a GNU compiler bundled into an IDE called simply fortran. A free trial can be downloaded on their website: http://simplyfortran.com/  This is for my custom version that is modified from the development team version 8.1 and under my own licence (not actually EPX)  With simply fortran I use the following compiler flags: -cpp -ffree-line-length-none -Wtabs -fbacktrace -Wno-align-commons -w 

Also I wonder how I might contribute my code to EPX? (I did not notice any way to contribute on the site...)

Jeremiah D. Crossett  | Senior Analyst  |  Phase Change Energy Solutions

120 E. Pritchard St.  | Asheboro, NC 27203  | Mobile 503-688-8951

www.phasechange.com 

  

On Tue, Oct 29, 2013 at 2:25 PM, Mengsong Zou <mengs...@gmail.com> wrote:

Hi,

This is the first time I've been trying to work with EnergyPlus. I downloaded the source code, but have no idea of how to compile and run it in Linux(Scientific linux). Is there anyone can help me or give me a link to some tutorial?

I looked this page:
http://bigladdersoftware.com/epx/developer-tutorial/build-from-command-line.html
But the method they provide is not working because when I'm doing
cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE:STRING=RELEASE ../../SourceCode/

I got an error:
CMake Error: The source directory "~/Research/EnergyPlus/energyplus-8.0.0.008-source/SourceCode" does not appear to contain CMakeLists.txt.

So basically I'm stuck here. Any help is really appreciated!

Thanks.

Best,
Mengsong

On Wednesday, July 18, 2012 4:54:32 AM UTC-4, Clayton Miller wrote:

If you're a student or an academic then check out Intel's student rates - $50-150!:

http://software.intel.com/en-us/articles/intel-education-offerings/

You can then get Microsoft Visual Studio for free as a student or startup:

http://www.microsoft.com/bizspark/

https://www.dreamspark.com/

On Tuesday, July 17, 2012 10:07:40 PM UTC+8, Neal Kruis wrote:

In the top directory you should find a document titled "SourceReadme.pdf". This provides a brief discussion on compiling EnergyPlus.

Currently the EnergyPlus development team uses Intel Visual Fortran to build their releases. In the future, we hope to post instructions on compiling with a free, open-source compiler such as GFortran.

Neal Kruis

On Tuesday, July 17, 2012 6:26:33 AM UTC-6, Dragan Cvetkovic wrote:

I have a problem with compiling a EnergyPlus opensource code.

Which compiler to use?

--
You received this message because you are subscribed to the Google Groups "EPx Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to epx-developer...@googlegroups.com.

To post to this group, send email to epx-dev...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/epx-developers/cbed0de1-6569-4d0c-b23a-a5b9413e2467%40googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "EPx Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to epx-developer...@googlegroups.com.
To post to this group, send email to epx-dev...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/epx-developers/c1b285a8-8e76-4706-b95b-9a19b0e3c24b%40googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

[Peter Ellis]

Hi Jeremiah,

Thanks for posting your code. And sorry for the delay. If you would like to contribute code, you need to start by telling us the following:

1. What is the new feature or bug fix that you are addressing?

2. Why is it needed?

3. What testing have you done to verify that the code is correct?

Nonetheless, I have given your code a preliminary review. You have a TON of changes and new code in there. It's hard to tell what you are trying to do. You might want to diff your code against the code released for EnergyPlus 8.1.0.008 (same as the EPx trunk). It might be that your changes were based on an earlier code base, so some of the diffs could actually be reintroducing old code.

Thanks,
P

[Jeremiah Crossett]

Peter, 

Thanks for the reply.  Quick answers to your questions in line.. Yes this work is based on the code explained in paper I gave you a copy of last time we met in Denver, and presented by the original developer at last years summer ASHRAE conference. I have attached this paper and a couple of model report that where done using this code. 

1. What is the new feature or bug fix that you are addressing?

• PCM Hysteresis modeling capabilities. 
  
• A method to count the physical state of the PCM, very useful for determining PCM performance. 

2. Why is it needed?

• Some PCM's express hysteresis and thus can not be properly modeled with the single linear curve approach employed in the current version of Energy Plus,  this work solves that issue by providing hysteresis modeling capabilities. 
  
• Without a counting system for the physical state of the PCM it is impossible to know how the PCM is performing, the PCM state output solves this issue. 

3. What testing have you done to verify that the code is correct?

• I have done ASHRAE 140 tests that show the new model to be very close the current model.
  
• I have used the new code on a few residential and a couple commercial models that indicate the new code is performing as intended. 

Nonetheless, I have given your code a preliminary review. You have a TON of changes and new code in there. It's hard to tell what you are trying to do. You might want to diff your code against the code released for EnergyPlus 8.1.0.008 (same as the EPx trunk). It might be that your changes were based on an earlier code base, so some of the diffs could actually be reintroducing old code.

• I have done extensive DIFF using an advanced diff/merge software, it is fully EnergyPlus 8.1.0.008, with the new code added to it.
• The new code is segmented from the current code by commented text brackets, so !VE START (new code starts below this line)  !VE END (new code ends at this line) and !VE START@xyz (new code starts at  "xyz" text)
• The only changes to the EnergyPlus 8.1.0.008 code are cleanup of messy/misspelled comments. 

The code may have some issues, or could possibly be further enhanced by other users, however I have been using it for the last few months and it seems to work fine----

Given the open source nature of the Epx project, my assumption is that if the code is contributed to the project that it may be further modified and that it would not need to be 100% perfect in order to be a development branch. If it was a branch, then it would be at the discretion of the users to use it, or modify it as they see fit.  From what I can tell, there have not been any other contributions from Epx users, so I had imagined that this contribution would be welcomed by the group. I expect that I will be able to get this code into the C++ version of EnergyPlus within the next couple of years, and hope that I can contribute this FORTRAN version to Epx now so that other users have the opportunity to use and/or modify it as they see fit. 

Please let me know if you need more from me in order to contribute my work, or if anyone has further questions. 

Kindest of regards 

--
You received this message because you are subscribed to the Google Groups "EPx Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to epx-developer...@googlegroups.com.
To post to this group, send email to epx-dev...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/epx-developers/bfe88f5f-b670-4efe-b7bd-caf99f44689f%40googlegroups.com.

[Jeremiah Crossett]

Peter, 

Probably the most interisting / useful element of my proposed contribution to Epx is the new output for PCM state. 

Below is the IO refrence to this, and time bin results for a typical surface and charts of the same surface. Also attached is an HTML report with PCM state output in time bins, and a CSV with hourly PCM state typical surfaces used in this model.  Hopefully this example helps to illustrate how the output is useful, as I find the output very useful for designing with PCM's, and think that other would as well. 

Report: CONDFD SURFACE PHASE CHANGE STATE NODE 5 []

For: SOUTH WALL

Timestamp: 2014-01-30 13:17:02

Values in table are in hours.

Time Bin Results

	-	1	2	3	4	5	-	-
Interval Start	less than	-2.0<=	-1.0<=	0.00<=	1.00<=	2.00<=	equal to or more than	Row
Interval End	-2.0	-1.0>	0.00>	1.00>	2.00>	3.00>	3.00	Total
January	0.00	0.00	0.00	0.00	186.70	557.30	0.00	744.00
February	0.00	1.05	1.40	0.00	278.25	391.30	0.00	672.00
March	0.00	1.20	1.50	0.00	382.80	358.50	0.00	744.00
April	0.00	23.10	28.70	0.00	449.10	219.10	0.00	720.00
May	0.00	38.20	66.30	0.00	486.35	153.15	0.00	744.00
June	0.00	157.05	288.90	0.00	191.25	82.80	0.00	720.00
July	0.00	256.45	449.90	0.00	24.25	13.40	0.00	744.00
August	0.00	277.75	405.85	0.00	42.70	17.70	0.00	744.00
September	0.00	157.00	202.20	0.00	280.15	80.65	0.00	720.00
October	0.00	47.25	72.60	0.00	449.55	174.60	0.00	744.00
November	0.00	0.00	0.00	0.00	320.90	399.10	0.00	720.00
December	0.00	0.00	0.00	0.00	170.25	573.75	0.00	744.00
12:01 to 1:00 am	0.00	80.55	11.90	0.00	190.55	82.00	0.00	365.00
1:01 to 2:00 am	0.00	72.40	10.50	0.00	193.00	89.10	0.00	365.00
2:01 to 3:00 am	0.00	69.55	7.30	0.00	188.75	99.40	0.00	365.00
3:01 to 4:00 am	0.00	67.75	5.30	0.00	178.75	113.20	0.00	365.00
4:01 to 5:00 am	0.00	62.35	2.45	0.00	173.45	126.75	0.00	365.00
5:01 to 6:00 am	0.00	51.15	4.50	0.00	171.90	137.45	0.00	365.00
6:01 to 7:00 am	0.00	35.85	16.15	0.00	172.60	140.40	0.00	365.00
7:01 to 8:00 am	0.00	7.05	44.95	0.00	156.65	156.35	0.00	365.00
8:01 to 9:00 am	0.00	0.70	52.75	0.00	121.85	189.70	0.00	365.00
9:01 to 10:00 am	0.00	0.00	66.40	0.00	52.10	246.50	0.00	365.00
10:01 to 11:00 am	0.00	0.00	78.80	0.00	28.85	257.35	0.00	365.00
11:01 to 12:00 pm	0.00	0.00	97.40	0.00	19.60	248.00	0.00	365.00
12:01 to 1:00 pm	0.00	0.10	121.45	0.00	17.95	225.50	0.00	365.00
1:01 to 2:00 pm	0.00	1.00	140.15	0.00	30.85	193.00	0.00	365.00
2:01 to 3:00 pm	0.00	2.80	147.40	0.00	66.75	148.05	0.00	365.00
3:01 to 4:00 pm	0.00	3.70	153.35	0.00	123.30	84.65	0.00	365.00
4:01 to 5:00 pm	0.00	16.70	142.95	0.00	152.05	53.30	0.00	365.00
5:01 to 6:00 pm	0.00	33.40	121.70	0.00	162.15	47.75	0.00	365.00
6:01 to 7:00 pm	0.00	43.35	104.05	0.00	165.85	51.75	0.00	365.00
7:01 to 8:00 pm	0.00	53.60	82.50	0.00	171.30	57.60	0.00	365.00
8:01 to 9:00 pm	0.00	72.85	53.75	0.00	175.95	62.45	0.00	365.00
9:01 to 10:00 pm	0.00	94.15	27.75	0.00	176.95	66.15	0.00	365.00
10:01 to 11:00 pm	0.00	98.70	13.45	0.00	182.65	70.20	0.00	365.00
11:01 to 12:00 am	0.00	91.35	10.45	0.00	188.45	74.75	0.00	365.00
Total	0.00	959.05	1517.35	0.00	3262.25	3021.35	0.00	8760.00

Statistics

	Statistic
Minimum	-2.0
Mean minus two standard deviations	-2.1
Mean	0.67
Mean plus two standard deviations	3.44
Maximum	2.00
Standard deviation	1.38

[Jeremiah Crossett]

Sorry, I attached the wrong csv-- correct one attached here.. 

[Peter Ellis]

Hi Jeremiah,

I'm afraid it's beyond our current capacity to evaluate so many changes and so much new code. Your changes modify so much of the finite difference solution method that it would require a significant effort to test and ensure the validity of the code.

At this stage, contributions to EPx would ideally be surgical changes such as a neatly delineated bug fix or an isolated new feature that doesn't interfere with any existing functionality, e.g., break the interface or change the answers for other objects. For bigger changes, it would be better to work with you from the beginning to help you define the scope of your modifications.

If you want to discuss further, you can email me directly.

Thanks,
P