Stop R16 support

[Sergey Prokhorov]

I really would like to discontinue support of epgsql on Erlang R16.

See https://github.com/epgsql/epgsql/issues/162 for details

Is there anyone who really need this?

[Marc Worrell]

I am all for ending R16 support.

More and more open source projects are abandoning R16, and even 17.

In general, supporting the last three major revisions should be ok.

If the code is then still compatible with an older version is a “nice to have” but definitely not a "must have”.

As 21 just came out (wouldn’t use it in production just yet though…) that would make our list of versions to support:

 - 21

 - 20

 - 19

 - 18 (nice to have)

 - 17 (only if it happens to run)

Maps and other enhancements are really good, so that is the way forward.

- Marc

--
You received this message because you are subscribed to the Google Groups "Erlang epgsql Postgres driver use and development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to epgsql+un...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Сергей Прохоров]

Thanks for your input, Marc.

Ok, I released 4.1.0 https://github.com/epgsql/epgsql/releases/tag/4.1.0 that supports Erlang from R16 to 21 and it expected to be the last release that supports R16.

I plan to drop all the workarounds added because of R16 (eg, `rebar.script`, `-ifdef(HAVE_MAPS)`). Probably would use maps as internal options storage instead of proplists.

Erlang 17 should be ok, because, AFAIK, the only place where we have Erl 17 - specific code is here https://github.com/epgsql/epgsql/blob/master/src/epgsql_oid_db.erl#L151-L195 and it's relatively small and easy.

вт, 26 июн. 2018 г. в 11:01, Marc Worrell <mwor...@me.com>:

[Marc Worrell]

Sounds good to me.

Maybe add an issue or note that in due time we could remove the ‘FAST_MAPS’ in epgsql_oid_db.erl

Especially as it is just an optimization (bad performance luck for the OTP-17 users…)

- Marc

[David Welton]

Hi,

Fine with ending that too. Perhaps add something in the docs along
the lines of "if you need support for R16, check out 4.1.0" ?

David N. Welton

http://www.welton.it/davidw/

http://www.dedasys.com/

[Сергей Прохоров]

For example, in rebar3 they just mentioned end of R16 support in release notes:

https://github.com/erlang/rebar3/releases/tag/3.5.3

вт, 26 июн. 2018 г. в 20:33, David Welton <davidn...@gmail.com>:

[Сергей Прохоров]

PR is out https://github.com/epgsql/epgsql/pull/165

вт, 26 июн. 2018 г. в 20:56, Сергей Прохоров <seri...@gmail.com>: