MHD-CT PR

5 views
Skip to first unread message

david collins

unread,
Apr 12, 2013, 1:30:45 PM4/12/13
to enzo...@googlegroups.com
Hi, all--

As far as I can tell, most of the details for the MHD-CT pr have been taken care of.  This includes a re-write of the primary routine in C, and an elimination of Grid_SolveMHDEquations.  Grid_SolveMHD_Li is now called from SolveHydroEquations.  Now it also accepts an arbitrary number of color fields.  If anyone has any further comments, let me know.  Otherwise it will get pulled in shortly.

It passes all tests in the push suite but one.  The one issue is that PhotonTestAMR now fails.  I've tracked this down to an issue that is only exposed by MHDCT, not caused by it.  I'll send that out in another email.  

Thanks!
d.

Nathan Goldbaum

unread,
Apr 12, 2013, 1:40:36 PM4/12/13
to enzo...@googlegroups.com
Hey Dave,

Would you mind updating the PR to reflect the current state of your work on this?

-Nathan

--
You received this message because you are subscribed to the Google Groups "enzo-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to enzo-dev+u...@googlegroups.com.
To post to this group, send email to enzo...@googlegroups.com.
Visit this group at http://groups.google.com/group/enzo-dev?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

David Collins

unread,
Apr 12, 2013, 2:24:10 PM4/12/13
to enzo...@googlegroups.com
Done.

j s oishi

unread,
Apr 12, 2013, 2:25:09 PM4/12/13
to enzo...@googlegroups.com
Hi all,

I have a few minor but useful updates to push to MHD-CT. David, I'll
issue a PR to your mhdct-final.

j

David Collins

unread,
Apr 12, 2013, 2:34:34 PM4/12/13
to enzo...@googlegroups.com
Great, thanks Jeff!

#ifdef MHDCT got removed, and useMHDCT got changed to UseMHDCT, so watch out for those.

j s oishi

unread,
Apr 12, 2013, 2:36:17 PM4/12/13
to enzo...@googlegroups.com
yeah, I got caught by that, but fixed both yesterday, I think. This PR
should reflect those changes...did I miss any?
Reply all
Reply to author
Forward
0 new messages