Individual Stars PR

5 views
Skip to first unread message

Andrew Emerick

unread,
Oct 24, 2019, 3:25:46 PM10/24/19
to enzo...@googlegroups.com
Hi all,

One of my long term goals for a while now is to submit a PR with my individual star formation / stellar feedback and chemical evolution model. I've started actually working towards this a bit cleaning up my code. It will be a large-ish PR, and there are many bits of the code that still need work before its completely ready. 

To help me visualize all the parts that still need work, and to motivate me to actually work on this regularly I was wondering if it would be reasonable to open a PR now (or relatively soon) and mark it as a work in progress, with the understanding that I don't have a hard plan for when it will be completely ready. Or, should I hold off a bit to try and minimize the amount of time this sits as a PR?



Cheers,
Andrew
---
Pasadena Fellow in Theoretical Astrophysics
Carnegie Observatories
California Institute of Technology

Greg Bryan

unread,
Oct 25, 2019, 8:58:35 AM10/25/19
to enzo...@googlegroups.com
Andrew — I would think a WIP is quite appropriate for this (but others should feel free to disagree).

Greg

--
You received this message because you are subscribed to the Google Groups "enzo-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to enzo-dev+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/enzo-dev/CAOo4WKLfYmFc%2By8FPGFtoN90SX1Hx_w2GjgvMhxbDrtBLLdoKw%40mail.gmail.com.

Brian O'Shea

unread,
Oct 25, 2019, 9:08:58 AM10/25/19
to enzo-dev
I concur - a WIP PR is absolutely appropriate, and I'm happy to look it over and comment on it!

--Brian

Tom Abel

unread,
Oct 25, 2019, 9:22:02 AM10/25/19
to enzo...@googlegroups.com
Oh fantastic Andrew. We will be so happy to see what you are up to and perhaps we can even help!!
Tom

Typed on an IPhone. Please excuse typos and surprising autocorrects. 

On Oct 25, 2019, at 6:08 AM, Brian O'Shea <bwo...@gmail.com> wrote:



Andrew Emerick

unread,
Oct 25, 2019, 1:31:50 PM10/25/19
to enzo...@googlegroups.com
Thanks all. I'll open this up as  PR within the next week. Trying to iron out a couple bugs first that came up merging this with all of the updates in the last year or so. 



Best,
Andrew


---
Pasadena Fellow in Theoretical Astrophysics
Carnegie Observatories
California Institute of Technology

Wise, John H

unread,
Oct 25, 2019, 1:38:56 PM10/25/19
to enzo...@googlegroups.com
This is great, Andrew! I'd be happy to review the PR next week, and I
agree that it should be a WIP one.

John

On 10/25/19 1:31 PM, Andrew Emerick wrote:
> Thanks all. I'll open this up as  PR within the next week. Trying to
> iron out a couple bugs first that came up merging this with all of the
> updates in the last year or so.
>
>
>
> Best,
> Andrew
>
>
> ---
> Pasadena Fellow in Theoretical Astrophysics
> Carnegie Observatories
> California Institute of Technology
>
>
> On Fri, Oct 25, 2019 at 6:22 AM Tom Abel <yip...@gmail.com
> <mailto:yip...@gmail.com>> wrote:
>
> Oh fantastic Andrew. We will be so happy to see what you are up to
> and perhaps we can even help!!
> Tom
>
> Typed on an IPhone. Please excuse typos and surprising autocorrects.
>
>> On Oct 25, 2019, at 6:08 AM, Brian O'Shea <bwo...@gmail.com
>> <mailto:bwo...@gmail.com>> wrote:
>>
>> 
>> I concur - a WIP PR is absolutely appropriate, and I'm happy to
>> look it over and comment on it!
>>
>> --Brian
>>
>> On Fri, Oct 25, 2019 at 8:58 AM Greg Bryan <gbry...@gmail.com
>> <mailto:gbry...@gmail.com>> wrote:
>>
>> Andrew — I would think a WIP is quite appropriate for this
>> (but others should feel free to disagree).
>>
>> Greg
>>
>>> On Oct 24, 2019, at 3:25 PM, Andrew Emerick
>>> <mailto:enzo-dev+u...@googlegroups.com>.
>>> <https://groups.google.com/d/msgid/enzo-dev/CAOo4WKLfYmFc%2By8FPGFtoN90SX1Hx_w2GjgvMhxbDrtBLLdoKw%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>>
>> --
>> You received this message because you are subscribed to the
>> Google Groups "enzo-dev" group.
>> To unsubscribe from this group and stop receiving emails from
>> it, send an email to enzo-dev+u...@googlegroups.com
>> <mailto:enzo-dev+u...@googlegroups.com>.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/enzo-dev/1FD85F9A-4544-471A-9B4E-E26B0BE30566%40gmail.com
>> <https://groups.google.com/d/msgid/enzo-dev/1FD85F9A-4544-471A-9B4E-E26B0BE30566%40gmail.com?utm_medium=email&utm_source=footer>.
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "enzo-dev" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to enzo-dev+u...@googlegroups.com
>> <mailto:enzo-dev+u...@googlegroups.com>.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/enzo-dev/CALf5AiBD7ERRvOOoOyM3_w%3DsdpDxTLif4A3Mo3Tcq6L1_z6Ccw%40mail.gmail.com
>> <https://groups.google.com/d/msgid/enzo-dev/CALf5AiBD7ERRvOOoOyM3_w%3DsdpDxTLif4A3Mo3Tcq6L1_z6Ccw%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "enzo-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to enzo-dev+u...@googlegroups.com
> <mailto:enzo-dev+u...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/enzo-dev/A3BFF94A-5D3C-4924-B4A9-F722EB8C743D%40gmail.com
> <https://groups.google.com/d/msgid/enzo-dev/A3BFF94A-5D3C-4924-B4A9-F722EB8C743D%40gmail.com?utm_medium=email&utm_source=footer>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "enzo-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to enzo-dev+u...@googlegroups.com
> <mailto:enzo-dev+u...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/enzo-dev/CAOo4WKJ7ehEm%2BvuV3hEDDMu%3DBuRYeY-3JYJK1yoOzYxsouVCdw%40mail.gmail.com
> <https://groups.google.com/d/msgid/enzo-dev/CAOo4WKJ7ehEm%2BvuV3hEDDMu%3DBuRYeY-3JYJK1yoOzYxsouVCdw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
John Wise
Associate Professor of Physics
Center for Relativistic Astrophysics, Georgia Tech
http://cosmo.gatech.edu
Reply all
Reply to author
Forward
0 new messages