Outstanding Pull Requests

Matthew Turk

unread,

Mar 22, 2012, 11:08:39 AM3/22/12

to enzo...@googlegroups.com

BitBucket shows five outstanding pull requests to the main Enzo
repository. The median age is 23 days.

Should the notification emails be forwarded to enzo-dev when a new PR
is issued? [+-][01]? I am a strong +1 on this.

(FWIW, all of these look good to me, but I think part of the PR
process is that we're supposed to have some degree of consensus on new
sets of changes.)

==

1) From Elizabeth:
https://bitbucket.org/enzo/enzo-dev/pull-request/25/small-changes-for-genum-in

This is a fix for GENum in adding a feedback sphere.

2) From John:
https://bitbucket.org/enzo/enzo-dev/pull-request/27/rebuildhierarchy-level-loop-revert

This changes behavior for RebuildHierarchy, but such that it can now
refine >1 level per call to RebuildHierarchy.

3) From Yuan:
https://bitbucket.org/enzo/enzo-dev/pull-request/28/fixed-small-error-partition-grid-only-if

This prevents double partitioning of grids in InitializeNew.C

4) From Sam and Cameron:
https://bitbucket.org/enzo/enzo-dev/pull-request/35/performance-tools

This is an awesome new set of functionality for measuring performance.
(Sam, Cameron, maybe you could introduce this on the list?)

5) From MikeK:
https://bitbucket.org/enzo/enzo-dev/pull-request/36/bugfix-in-determinenumberofnodesc

An important bug fix for repeated strings in nodes.

Cameron Hummels

unread,

Mar 22, 2012, 11:15:45 AM3/22/12

to enzo...@googlegroups.com

+1, although it might generate a lot of mail if people have
conversations in the comments of PRs, as it does on the yt list. I'm OK
with this, but it's just something to keep in mind.

Cameron

Greg Bryan

unread,

Mar 22, 2012, 11:42:18 AM3/22/12

to enzo...@googlegroups.com

+1

> --
> You received this message because you are subscribed to the Google Groups "enzo-dev" group.
> To post to this group, send email to enzo...@googlegroups.com.
> To unsubscribe from this group, send email to enzo-dev+u...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/enzo-dev?hl=en.
>

Britton Smith

unread,

Mar 22, 2012, 11:46:05 AM3/22/12

to enzo...@googlegroups.com

I am +1 on sending the emails to everyone. All of enzo-dev should be aware of the changes taking place in the main repo.

Brian O'Shea

unread,

Mar 22, 2012, 11:48:41 AM3/22/12

to enzo...@googlegroups.com

I agree with Britton. +1 to that. If you're on enzo-dev, you can handle the email!

David Collins

unread,

Mar 22, 2012, 11:52:39 AM3/22/12

to enzo...@googlegroups.com

+1. That's what the dev list is for.

d.

> --
> You received this message because you are subscribed to the Google Groups
> "enzo-dev" group.
> To post to this group, send email to enzo...@googlegroups.com.
> To unsubscribe from this group, send email to
> enzo-dev+u...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/enzo-dev?hl=en.
>

--
Sent from my computer.

j s oishi

unread,

Mar 22, 2012, 12:00:22 PM3/22/12

to enzo...@googlegroups.com

+1!

James Bordner

unread,

Mar 22, 2012, 12:01:54 PM3/22/12

to enzo...@googlegroups.com

+1

Sam Skillman

unread,

Mar 22, 2012, 12:02:08 PM3/22/12

to enzo...@googlegroups.com

+1. i'm addicted to emails.

Yuan Li

unread,

Mar 22, 2012, 2:27:37 PM3/22/12

to enzo...@googlegroups.com

+1

Michael Norman

unread,

Mar 22, 2012, 3:58:21 PM3/22/12

to enzo...@googlegroups.com

looks good to me. +1

Matthew Turk

unread,

Mar 23, 2012, 2:41:52 PM3/23/12

to enzo...@googlegroups.com

Thanks everybody -- I'll start forwarding new PRs to the list.

Also, after the three acceptances today (mostly the new performance
tools from Cameron and Sam!) we actually snuck up pretty high on the
CIA.vc list for the day, beating out Python... We're down to one PR
that's under active discussion. Awesome!