Can't get StatsD tags to work

[Kevin Chan]

Greetings!

I'm trying to take advantage of the changes merged in this PR, Add configurable stats tags #1852. I updated my Envoy version to the latest and switched to the v2 api, but no tags appeared! I flipped through the source, and it looks as if they're not being picked up by the StatsSink - I couldn't find any place MetricsImpl.tags() is invoked. Any advice?

Thanks!

/server_info: envoy c7bfe14d25c9803930fbee37d0acbe1e64999dcc/Clean/RELEASE live 343 343 0

excerpt from bootstrap.yaml:

    ...

    stats_sinks:

      - name: envoy.statsd

        config:

          address:

            socket_address:

              protocol: UDP

              address: 127.0.0.1

              port_value: 8125

    stats_config:

    admin:

    ...

[Matt Rice]

Hey Kevin,

You're correct.  As far as I'm aware, there are no sinks built into Envoy that take advantage of this today.  To do this, a new/modified sink will need to be developed to use them.  I would encourage you to open an issue on the topic to discuss.  

Thanks,

Matt

--
You received this message because you are subscribed to the Google Groups "envoy-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to envoy-users+unsubscribe@googlegroups.com.
To post to this group, send email to envoy...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/envoy-users/8af178a5-67f4-4489-be1e-36a4692dffdb%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Matt Klein]

What Matt said.

More fundamentally, statsd does not support tags. Eventually we will have native Prometheus export which is tracked here: https://github.com/envoyproxy/envoy/issues/1947. I'm assuming other providers will also eventually have direct support (influx, etc.).

To view this discussion on the web visit https://groups.google.com/d/msgid/envoy-users/CACP4Trdsohi5fb42w3MP3zViVQFU11g3WFjayxo4k6e3%3DfaqHA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Matt Klein

Software Engineer

mkl...@lyft.com

https://calendly.com/mattklein123