Deviation from documented behaviour for onRequestHeaders

[Harish Ganesan]

Hi all,

We are trying to add some authentication logic to envoy through the wasm http filter.The documentation for the return values of `onRequestHeaders` has a `ContinueAndEndStream` , which is supposed to "terminate the stream". But I noticed that when I return this from my wasm code for `onRequestHeaders`, it didn't terminate the stream but instead proceeded to the next stages.

In the envoy code, I notice that `ContinueAndEndStream` is ignored, and if it is returned it is handled like `Continue`. Shouldn't this behaviour atleast be documented somewhere ? Also is there a way to actually terminate a stream through the return value of `onRequestHeaders`, as closing the stream using `closeRequest` seems to be crashing envoy altogether. 

Thanks.

CONFIDENTIALITY NOTICE: This E-Mail is intended only for the individual or entity to which it is addressed and may contain information that is confidential. If you have received this communication in error, do not distribute. Please delete the original message and immediately notify the sender.

[Yan Avlasov]

Hi Harish,

please open an Issue on GitHub. It will let us track this for future work.

Yan

--
You received this message because you are subscribed to the Google Groups "envoy-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to envoy-dev+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/envoy-dev/8befcd9f-65cb-40e1-97dd-742461a5d641n%40googlegroups.com.

[Harish Ganesan]

I have created an issue here now. My intent though was to find out if we are missing something obvious, regarding the return values of onRequestHeaders. Can i get some suggestions there ?